habanalabs: remove write_open_cnt property
Subsystems (2)
PATCH 1/1 habanalabs: remove write_open_cnt property
This property has attempted to show the number of open file descriptors on the device. This was a stupid and futile attempt so remove this property completely.
Signed-off-by Oded Gabbay <[email protected]>
--- Documentation/ABI/testing/sysfs-driver-habanalabs | 9 +-------- drivers/misc/habanalabs/sysfs.c | 10 ---------- 2 files changed, 1 insertion(+), 18 deletions(-)
Documentation/ABI/testing/sysfs-driver-habanalabs +1 -8
@@ -186,11 +186,4 @@ What: /sys/class/habanalabs/hl<n>/uboot_ver Date: Jan 2019 KernelVersion: 5.1 Contact: [email protected] -Description: Version of the u-boot running on the device's CPU - -What: /sys/class/habanalabs/hl<n>/write_open_cnt -Date: Jan 2019 -KernelVersion: 5.1 -Contact: [email protected] -Description: Displays the total number of user processes that are currently - opened on the device's file +Description: Version of the u-boot running on the device's CPU
drivers/misc/habanalabs/sysfs.c +0 -10
@@ -351,14 +351,6 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr,return sprintf (buf,"%s\n" , str); } -static ssize_t write_open_cnt_show (struct device *dev, -struct device_attribute *attr,char *buf) -{ -struct hl_device *hdev =dev_get_drvdata (dev); - -return sprintf (buf,"%d\n" , hdev->user_ctx ?1 :0 ); -} -static ssize_t soft_reset_cnt_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -461,7 +453,6 @@ static DEVICE_ATTR_RO(soft_reset_cnt);static DEVICE_ATTR_RO (status);static DEVICE_ATTR_RO (thermal_ver);static DEVICE_ATTR_RO (uboot_ver); -static DEVICE_ATTR_RO (write_open_cnt);static struct bin_attribute bin_attr_eeprom = { .attr = {.name ="eeprom" , .mode = (0444 )},
@@ -488,7 +479,6 @@ static struct attribute *hl_dev_attrs[] = { &dev_attr_status.attr, &dev_attr_thermal_ver.attr, &dev_attr_uboot_ver.attr, - &dev_attr_write_open_cnt.attr, NULL, };
Signature · 1 line
2.17.1
Quoted 5 lines · Oded Gabbay
This property has attempted to show the number of open file descriptors on the device. This was a stupid and futile attempt so remove this property completely.
Signed-off-by Oded Gabbay <[email protected]>
Reviewed-by Greg Kroah-Hartman <[email protected]>