percpu: fix pcpu_page_first_chunk return code handling
Subsystems (2)
PATCH 1/1 percpu: fix pcpu_page_first_chunk return code handling
gcc complains that pcpu_page_first_chunk() might return an uninitialized error code when the loop is never entered:
mm/percpu.c: In function 'pcpu_page_first_chunk':mm/percpu.c:2929:9: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Make it return zero like before the cleanup.
--- mm/percpu.c | 1 + 1 file changed, 1 insertion(+)
mm/percpu.c +1 -0
@@ -2917,6 +2917,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size, ai->reserved_size, ai->dyn_size);pcpu_setup_first_chunk (ai, vm.addr); + rc =0 ; goto out_free_ar; enomem:
Signature · 1 line
2.20.0
Dennis Zhou
maintainerQuoted 29 lines · Arnd Bergmann
gcc complains that
pcpu_page_first_chunk()might return an uninitialized error code when the loop is never entered:
mm/percpu.c: In function 'pcpu_page_first_chunk':mm/percpu.c:2929:9: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized]Make it return zero like before the cleanup.
Fixes a13e0ad81216 ("percpu: Make pcpu_setup_first_chunk() void function")Signed-off-by Arnd Bergmann <[email protected]>--- mm/percpu.c | 1 + 1 file changed, 1 insertion(+)mm/percpu.c +1
-0@@ -2917,6 +2917,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size, ai->reserved_size, ai->dyn_size);pcpu_setup_first_chunk (ai, vm.addr); + rc =0 ; goto out_free_ar; enomem:Signature · 1 line
2.20.0
Hi Arnd,
I got the report for the kbuild bot. I have the fix in my tree already.
Thanks,
Dennis