Skip to contentSkip to conversation

sunrpc/cache: remove the exporting of cache_seq_next

PATCH In review Denis Efremov 2 participants 2 messages Jul 8, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunrpc/cache: remove the exporting of cache_seq_next

The function cache_seq_next is declared static and marked EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the function is not used outside of the net/sunrpc/cache.c file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Fixes d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup")
---
 net/sunrpc/cache.c | 1 -
 1 file changed, 1 deletion(-)
net/sunrpc/cache.c +0 -1
index 66fbb9d2fba7..6f1528f271ee 100644
@@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos)
 				hlist_first_rcu(&cd->hash_table[hash])),
 				struct cache_head, cache_list);
 }
-EXPORT_SYMBOL_GPL(cache_seq_next);
 
 void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos)
 	__acquires(RCU)
Signature · 1 line
2.21.0
#1 lore raw

Makes sense, thanks; apply for 5.3.--b.

Quoted 25 lines · Denis Efremov

The function cache_seq_next is declared static and marked EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the function is not used outside of the net/sunrpc/cache.c file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Fixes d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup")
---
 net/sunrpc/cache.c | 1 -
 1 file changed, 1 deletion(-)
net/sunrpc/cache.c +0 -1
index 66fbb9d2fba7..6f1528f271ee 100644
@@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos)
 				hlist_first_rcu(&cd->hash_table[hash])),
 				struct cache_head, cache_list);
 }
-EXPORT_SYMBOL_GPL(cache_seq_next);
 
 void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos)
 	__acquires(RCU)
Signature · 1 line
2.21.0