Skip to contentSkip to conversation

scsi: libsas: remove the exporting of sas_wait_eh

PATCH Applied Denis Efremov 3 participants 3 messages Jul 8, 2019 – Jul 12, 2019

Subsystems (2)
SCSI SCSI libsas
lore
Share & tools
lore

Denis Efremov

author
#0 lore raw

PATCH 1/1 scsi: libsas: remove the exporting of sas_wait_eh

The function sas_wait_eh is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Signed-off-by Denis Efremov <[email protected]>
---
 drivers/scsi/libsas/sas_scsi_host.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/libsas/sas_scsi_host.c +0 -1
index ede0674d8399..5564d3f1243a 100644
@@ -414,7 +414,6 @@ static void sas_wait_eh(struct domain_device *dev)
 		goto retry;
 	}
 }
-EXPORT_SYMBOL(sas_wait_eh);
 
 static int sas_queue_reset(struct domain_device *dev, int reset_type,
 			   u64 lun, int wait)
Signature · 1 line
2.21.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Denis Efremov

The function sas_wait_eh is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Signed-off-by Denis Efremov <[email protected]>
---
  drivers/scsi/libsas/sas_scsi_host.c | 1 -
  1 file changed, 1 deletion(-)
drivers/scsi/libsas/sas_scsi_host.c +0 -0
index ede0674d8399..5564d3f1243a 100644

drivers/scsi/libsas/sas_scsi_host.c static void sas_wait_eh(struct domain_device *dev) · line 419

Quoted 7 lines
drivers/scsi/libsas/sas_scsi_host.c +0 -1
@@ -414,7 +414,6 @@ static void sas_wait_eh(struct domain_device *dev)
  		goto retry;
  	}
  }
-EXPORT_SYMBOL(sas_wait_eh);
 
  static int sas_queue_reset(struct domain_device *dev, int reset_type,
  			   u64 lun, int wait)
Reviewed-by Jason Yan <[email protected]>
Applied
#2 lore raw
In reply to Denis Efremov

Denis,

Quoted 4 lines

The function sas_wait_eh is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Applied to 5.3/scsi-fixes, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering