Skip to contentSkip to conversation

Input: synaptics-rmi4 - remove the exporting of rmi_2d_sensor_set_input_params

PATCH Applied Denis Efremov 2 participants 2 messages Jul 8, 2019 – Jul 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: synaptics-rmi4 - remove the exporting of rmi_2d_sensor_set_input_params

The function rmi_2d_sensor_set_input_params is declared static and marked EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the function is not used outside of the drivers/input/rmi4/rmi_2d_sensor.c file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

---
 drivers/input/rmi4/rmi_2d_sensor.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/rmi4/rmi_2d_sensor.c +0 -1
index ea549efe4bc4..b7fe6eb35a4e 100644
@@ -204,7 +204,6 @@ static void rmi_2d_sensor_set_input_params(struct rmi_2d_sensor *sensor)
 	if (sensor->topbuttonpad)
 		set_bit(INPUT_PROP_TOPBUTTONPAD, input->propbit);
 }
-EXPORT_SYMBOL_GPL(rmi_2d_sensor_set_input_params);
 
 int rmi_2d_sensor_configure_input(struct rmi_function *fn,
 					struct rmi_2d_sensor *sensor)
Signature · 1 line
2.21.0
maintainer Applied
#1 lore raw
Quoted 6 lines · Denis Efremov

The function rmi_2d_sensor_set_input_params is declared static and marked EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the function is not used outside of the drivers/input/rmi4/rmi_2d_sensor.c file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Applied, thank you.

Quoted 19 lines
---
 drivers/input/rmi4/rmi_2d_sensor.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/rmi4/rmi_2d_sensor.c +0 -1
index ea549efe4bc4..b7fe6eb35a4e 100644
@@ -204,7 +204,6 @@ static void rmi_2d_sensor_set_input_params(struct rmi_2d_sensor *sensor)
 	if (sensor->topbuttonpad)
 		set_bit(INPUT_PROP_TOPBUTTONPAD, input->propbit);
 }
-EXPORT_SYMBOL_GPL(rmi_2d_sensor_set_input_params);
 
 int rmi_2d_sensor_configure_input(struct rmi_function *fn,
 					struct rmi_2d_sensor *sensor)
Signature · 1 line
2.21.0
Signature · 1 line
Dmitry