drm/amdgpu: add missing documentation on new module parameters
Subsystems (2)
PATCH 1/3 drm/amdgpu: add missing documentation on new module parameters
New parameters added for navi lack documentation.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +13 -0
@@ -581,14 +581,27 @@ MODULE_PARM_DESC(async_gfx_ring, "Asynchronous GFX rings that could be configured with either different priorities (HP3D ring and LP3D ring), or equal priorities (0 = disabled, 1 = enabled (default))");module_param_named (async_gfx_ring, amdgpu_async_gfx_ring, int,0444 ); +/** +* DOC: mcbp (int) +* It is used to enable mid command buffer preemption. (0 = disabled (default), 1 = enabled) +*/ MODULE_PARM_DESC (mcbp,"Enable Mid-command buffer preemption (0 = disabled (default), 1 = enabled)" );module_param_named (mcbp, amdgpu_mcbp, int,0444 ); +/** +* DOC: discovery (int) +* Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM. +*/ MODULE_PARM_DESC (discovery,"Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM" );module_param_named (discovery, amdgpu_discovery, int,0444 ); +/** +* DOC: mes (int) +* Enable Micro Engine Scheduler. This is a new hw scheduling engine for gfx, sdma, and compute. +* (0 = disabled (default), 1 = enabled) +*/ MODULE_PARM_DESC (mes,"Enable Micro Engine Scheduler (0 = disabled (default), 1 = enabled)" );module_param_named (mes, amdgpu_mes, int,0444 );
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190708184811.6409-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
PATCH 2/3 drm/amdgpu: properly guard the generic discovery code
It's only available on navi and newer.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -2
@@ -2623,7 +2623,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,if (amdgpu_mes && adev->asic_type >=CHIP_NAVI10 ) adev->enable_mes = true; -if (amdgpu_discovery) { +if (amdgpu_discovery && adev->asic_type >=CHIP_NAVI10 ) { r =amdgpu_discovery_init (adev);if (r) {dev_err (adev->dev,"amdgpu_discovery_init failed\n" );
@@ -2891,7 +2891,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)amdgpu_ucode_sysfs_fini (adev);amdgpu_pmu_fini (adev);amdgpu_debugfs_preempt_cleanup (adev); -if (amdgpu_discovery) +if (amdgpu_discovery && adev->asic_type >=CHIP_NAVI10 )amdgpu_discovery_fini (adev); }
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/3 drm/amdgpu: enable IP discovery by default on navi
In reply to a message not in the archiveUse the IP discovery table rather than hardcoding the settings in the driver.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -1
@@ -140,7 +140,7 @@ uint amdgpu_smu_memory_pool_size = 0;uint amdgpu_dc_feature_mask =0 ;int amdgpu_async_gfx_ring =1 ;int amdgpu_mcbp =0 ; -int amdgpu_discovery =0 ; +int amdgpu_discovery =-1 ;int amdgpu_mes =0 ;struct amdgpu_mgpu_info mgpu_info = {
@@ -592,6 +592,7 @@ module_param_named(mcbp, amdgpu_mcbp, int, 0444);/** * DOC: discovery (int) * Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM. +* (-1 = auto (default), 0 = disabled, 1 = enabled) */ MODULE_PARM_DESC (discovery,"Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM" );
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190708184811.6409-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 3/3] drm/amdgpu: enable IP discovery by default on navi
Series is Reviewed-by: Xiaojie Yuan <[email protected]>
BR,
Xiaojie
Quoted 35 lines · Alex Deucher
Use the IP discovery table rather than hardcoding the settings in the driver.
Reviewed-by Xiaojie Yuan <[email protected]>Signed-off-by Alex Deucher <[email protected]>---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2
-1@@ -140,7 +140,7 @@ uint amdgpu_smu_memory_pool_size = 0;uint amdgpu_dc_feature_mask =0 ;int amdgpu_async_gfx_ring =1 ;int amdgpu_mcbp =0 ; -int amdgpu_discovery =0 ; +int amdgpu_discovery =-1 ;int amdgpu_mes =0 ;struct amdgpu_mgpu_info mgpu_info = {@@ -592,6 +592,7 @@ module_param_named(mcbp, amdgpu_mcbp, int, 0444);/** * DOC: discovery (int) * Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM. +* (-1 = auto (default), 0 = disabled, 1 = enabled) */ MODULE_PARM_DESC (discovery,"Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM" );Signature · 1 line
2.20.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx