Skip to contentSkip to conversation

hwmon: Correct struct allocation style

PATCH Guenter Roeck 1 participant 1 message Jul 9, 2019 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

Hi,

Quoted 8 lines · Fabian Schindlatz

Use sizeof(*var) instead of sizeof(struct var_type) as argument to kalloc() and friends to comply with the kernel coding style.

[groeck: Resolved comment conflict against -next]

This patch causes conflicts in -next due to commit 835896a59b95 ("hwmon/coretemp: Cosmetic: Rename internal variables to zones from packages"), which is not being submitted through the hwmon subsystem. Unfortunately, the conflicts are more substantial than I thought and not trivial. Since I have no control over the conflicting patch, I decided to drop this patch from the hwmon subsystem commit queue.

Please feel free to resubmit after the commit window closes. I would suggest to drop the coretemp driver from the patch since I don't know if further changes outside my control will be made to that driver.

Sorry for the trouble.

Guenter