Skip to contentSkip to conversation

FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

PATCH New Lukasz Majewski 2 participants 4 messages Jul 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

This patch fixes not enabled uart2 (and hence serial console) on i.MX53 devices. After following commit 1d255904c306 ("ARM: dts: imx: imx53:
Synchronize iMX53 DT with Linux") from the uart2 compatible the 'fsl,imx7d-uart' has been removed (which was correct).

However, the root cause of the problem was the commit 98d62e618bb9 ("arm:
imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this compatible.

Moreover, without this patch all i.MX53 UARTs are not usable as neither 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in drivers/serial/serial_mxc.c file.

The fix is to add 'fsl,imx53-uart' as a compatible for the aforementioned serial driver (it is also defined in the Linux kernel).

---

 drivers/serial/serial_mxc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/serial/serial_mxc.c +1 -0
index a435e68005..af40576f66 100644
@@ -342,6 +342,7 @@ static int mxc_serial_ofdata_to_platdata(struct udevice *dev)
 }
 
 static const struct udevice_id mxc_serial_ids[] = {
+	{ .compatible = "fsl,imx53-uart" },
 	{ .compatible = "fsl,imx6sx-uart" },
 	{ .compatible = "fsl,imx6ul-uart" },
 	{ .compatible = "fsl,imx7d-uart" },
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

Quoted 9 lines · Lukasz Majewski

This patch fixes not enabled uart2 (and hence serial console) on i.MX53 devices. After following commit 1d255904c306 ("ARM: dts: imx: imx53:
Synchronize iMX53 DT with Linux") from the uart2 compatible the 'fsl,imx7d-uart' has been removed (which was correct).

However, the root cause of the problem was the commit 98d62e618bb9 ("arm:
imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this compatible.

Quoted 8 lines

Moreover, without this patch all i.MX53 UARTs are not usable as neither 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in drivers/serial/serial_mxc.c file.

The fix is to add 'fsl,imx53-uart' as a compatible for the aforementioned serial driver (it is also defined in the Linux kernel).

The tags in subject should be "serial: mxc: ..."

drivers/serial/serial_mxc.c static int mxc_serial_ofdata_to_platdata(struct udevice *dev) · line 344

Quoted 13 lines

---

 drivers/serial/serial_mxc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/serial/serial_mxc.c +0 -0
index a435e68005..af40576f66 100644
@@ -342,6 +342,7 @@ static int mxc_serial_ofdata_to_platdata(struct udevice *dev)
 }
 
 static const struct udevice_id mxc_serial_ids[] = {

Add fsl,imx21-uart to catch all the remaining cases ?

Quoted 5 lines
drivers/serial/serial_mxc.c +1 -0
+	{ .compatible = "fsl,imx53-uart" },
 	{ .compatible = "fsl,imx6sx-uart" },
 	{ .compatible = "fsl,imx6ul-uart" },
 	{ .compatible = "fsl,imx7d-uart" },

[...]

#2 lore raw

PATCH 1/1 FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

Hi Marek,

Quoted 35 lines · Lukasz Majewski
Quoted 14 lines

This patch fixes not enabled uart2 (and hence serial console) on i.MX53 devices. After following commit 1d255904c306 ("ARM: dts:
imx: imx53: Synchronize iMX53 DT with Linux") from the uart2 compatible the 'fsl,imx7d-uart' has been removed (which was correct).

However, the root cause of the problem was the commit 98d62e618bb9 ("arm: imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this compatible.

Moreover, without this patch all i.MX53 UARTs are not usable as neither 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in drivers/serial/serial_mxc.c file.

Quoted 5 lines

The fix is to add 'fsl,imx53-uart' as a compatible for the aforementioned serial driver (it is also defined in the Linux kernel).

The tags in subject should be "serial: mxc: ..."

Quoted 12 lines

---

 drivers/serial/serial_mxc.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/serial/serial_mxc.c index a435e68005..af40576f66 100644

drivers/serial/serial_mxc.c +0 -0
@@ -342,6 +342,7 @@ static int mxc_serial_ofdata_to_platdata(struct
 udevice *dev) }
 
Quoted 4 lines

drivers/serial/serial_mxc.c static int mxc_serial_ofdata_to_platdata(struct udevice *dev) · line 344

Quoted 1 line
drivers/serial/serial_mxc.c +0 -0
 static const struct udevice_id mxc_serial_ids[] = {  

Add fsl,imx21-uart to catch all the remaining cases ?

I've posted v2 of this patch.

Just one question - I've noticed that there was some work done for m53 menlo board. It seems like it could be affected by this issue (if it uses serial console in u-boot).

Quoted 7 lines
Quoted 5 lines
drivers/serial/serial_mxc.c +1 -0
+	{ .compatible = "fsl,imx53-uart" },
 	{ .compatible = "fsl,imx6sx-uart" },
 	{ .compatible = "fsl,imx6ul-uart" },
 	{ .compatible = "fsl,imx7d-uart" },

[...]

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190709/fe69d9c0/attachment.sig>

#3 lore raw

PATCH 1/1 FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

Quoted 42 lines · Lukasz Majewski

Hi Marek,

Quoted 35 lines · Lukasz Majewski
Quoted 14 lines

This patch fixes not enabled uart2 (and hence serial console) on i.MX53 devices. After following commit 1d255904c306 ("ARM: dts:
imx: imx53: Synchronize iMX53 DT with Linux") from the uart2 compatible the 'fsl,imx7d-uart' has been removed (which was correct).

However, the root cause of the problem was the commit 98d62e618bb9 ("arm: imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this compatible.

Moreover, without this patch all i.MX53 UARTs are not usable as neither 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in drivers/serial/serial_mxc.c file.

Quoted 5 lines

The fix is to add 'fsl,imx53-uart' as a compatible for the aforementioned serial driver (it is also defined in the Linux kernel).

The tags in subject should be "serial: mxc: ..."

Quoted 12 lines

---

 drivers/serial/serial_mxc.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/serial/serial_mxc.c index a435e68005..af40576f66 100644

drivers/serial/serial_mxc.c +0 -0
@@ -342,6 +342,7 @@ static int mxc_serial_ofdata_to_platdata(struct
 udevice *dev) }
 
Quoted 4 lines

drivers/serial/serial_mxc.c static int mxc_serial_ofdata_to_platdata(struct udevice *dev) · line 344

Quoted 1 line
drivers/serial/serial_mxc.c +0 -0
 static const struct udevice_id mxc_serial_ids[] = {  

Add fsl,imx21-uart to catch all the remaining cases ?

Quoted 5 lines

I've posted v2 of this patch.

Just one question - I've noticed that there was some work done for m53 menlo board. It seems like it could be affected by this issue (if it uses serial console in u-boot).

Odd, when I tested it, I had no problem with serial console, but it would make sense that it is affected. I'll take a look.

[...]