Skip to contentSkip to conversation

mtd: rawnand: vf610_nfc: Add of_node_put() before goto

PATCH Applied Nishka Dasgupta 3 participants 3 messages Jul 9, 2019 – Jul 25, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: rawnand: vf610_nfc: Add of_node_put() before goto

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.

---
 drivers/mtd/nand/raw/vf610_nfc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/raw/vf610_nfc.c +1 -0
index e4fe8c4bc711..6b399a75f9ae 100644
@@ -862,6 +862,7 @@ static int vf610_nfc_probe(struct platform_device *pdev)
 				dev_err(nfc->dev,
 					"Only one NAND chip supported!\n");
 				err = -EINVAL;
+				of_node_put(child);
 				goto err_disable_clk;
 			}
 
Signature · 6 lines
2.19.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Nishka Dasgupta

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.

Looks good to me:

--
Stefan

Quoted 9 lines
---
 drivers/mtd/nand/raw/vf610_nfc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/raw/vf610_nfc.c +0 -0
index e4fe8c4bc711..6b399a75f9ae 100644

drivers/mtd/nand/raw/vf610_nfc.c static int vf610_nfc_probe(struct platform_device *pdev) · line 867

Quoted 6 lines
drivers/mtd/nand/raw/vf610_nfc.c +1 -0
@@ -862,6 +862,7 @@ static int vf610_nfc_probe(struct platform_device *pdev)
 				dev_err(nfc->dev,
 					"Only one NAND chip supported!\n");
 				err = -EINVAL;
+				of_node_put(child);
 				goto err_disable_clk;
 			}

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer Applied
#2 lore raw
In reply to Nishka Dasgupta
Quoted 8 lines · Nishka Dasgupta

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/