mtd: rawnand: vf610_nfc: Add of_node_put() before goto
Subsystems (3)
PATCH 1/1 mtd: rawnand: vf610_nfc: Add of_node_put() before goto
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.
--- drivers/mtd/nand/raw/vf610_nfc.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/nand/raw/vf610_nfc.c +1 -0
@@ -862,6 +862,7 @@ static int vf610_nfc_probe(struct platform_device *pdev)dev_err (nfc->dev,"Only one NAND chip supported!\n" ); err = -EINVAL ; +of_node_put (child); goto err_disable_clk; }
Signature · 6 lines
2.19.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 7 lines · Nishka Dasgupta
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the goto.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Looks good to me:
--
Stefan
Quoted 9 lines
--- drivers/mtd/nand/raw/vf610_nfc.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/nand/raw/vf610_nfc.c +0
-0
drivers/mtd/nand/raw/vf610_nfc.c static int vf610_nfc_probe(struct platform_device *pdev) · line 867
Quoted 6 lines
drivers/mtd/nand/raw/vf610_nfc.c +1
-0@@ -862,6 +862,7 @@ static int vf610_nfc_probe(struct platform_device *pdev)dev_err (nfc->dev,"Only one NAND chip supported!\n" ); err = -EINVAL ; +of_node_put (child); goto err_disable_clk; }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 8 lines · Nishka Dasgupta
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the goto.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>Reviewed-by Stefan Agner <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/