memory: ti-aemif: Add of_node_put() before goto
PATCH 1/1 memory: ti-aemif: Add of_node_put() before goto
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/memory/ti-aemif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/memory/ti-aemif.c +3 -1
@@ -378,8 +378,10 @@ static int aemif_probe(struct platform_device *pdev)*/ for_each_available_child_of_node (np, child_np) { ret =of_aemif_parse_abus_config (pdev, child_np); -if (ret <0 ) +if (ret <0 ) { +of_node_put (child_np); goto error; + } } }else if (pdata && pdata->num_abus_data >0 ) {for (i =0 ; i < pdata->num_abus_data; i++, aemif->num_cs++) {
Signature · 1 line
2.19.1