Skip to contentSkip to conversation

Fixed a brace styling issue

PATCH In review sheetalsingala 2 participants 2 messages Jul 10, 2019 – Jul 11, 2019 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Fixed a brace styling issue

Fixed a coding style issue

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -1
index bb99c8653aab..4a8b812605f3 100644
@@ -18,7 +18,7 @@
 
 #define VERSION "0.1"
 
-#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
+#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
 
 int btintel_check_bdaddr(struct hci_dev *hdev)
 {
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Hi,

Quoted 12 lines

Fixed a coding style issue

---
drivers/bluetooth/btintel.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +0 -0
index bb99c8653aab..4a8b812605f3 100644

drivers/bluetooth/btintel.c line 21

Quoted 5 lines
drivers/bluetooth/btintel.c +1 -1
@@ -18,7 +18,7 @@
 
 #define VERSION "0.1"
 
-#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
+#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})

maybe you want to test your patches before sending them.

CC drivers/bluetooth/btintel.o
drivers/bluetooth/btintel.c: In function ‘btintel_check_bdaddr’:
drivers/bluetooth/btintel.c:21:24: warning: missing braces around initializer [-Wmissing-braces]
21 | #define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
| ^
drivers/bluetooth/btintel.c:50:27: note: in expansion of macro ‘BDADDR_INTEL’

   50 |  if (!bacmp(&bda->bdaddr, BDADDR_INTEL)) {
      |                           ^~~~~~~~~~~~

Regards

Marcel