clk: imx8mq: set correct parent for usb ctrl clocks
PATCH 1/2 clk: imx8mq: set correct parent for usb ctrl clocks
From: Li Jun <[email protected]>
Per latest imx8mq datasheet of CCM, the parent of usb1_ctrl_root_clk and usb2_ctrl_root_clk is usb_bus.
--- drivers/clk/imx/clk-imx8mq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/imx/clk-imx8mq.c +2 -2
@@ -523,8 +523,8 @@ static int imx8mq_clocks_probe(struct platform_device *pdev) clks[IMX8MQ_CLK_UART2_ROOT ] =imx_clk_gate4 ("uart2_root_clk" ,"uart2" , base +0x44a0 ,0 ); clks[IMX8MQ_CLK_UART3_ROOT ] =imx_clk_gate4 ("uart3_root_clk" ,"uart3" , base +0x44b0 ,0 ); clks[IMX8MQ_CLK_UART4_ROOT ] =imx_clk_gate4 ("uart4_root_clk" ,"uart4" , base +0x44c0 ,0 ); - clks[IMX8MQ_CLK_USB1_CTRL_ROOT ] =imx_clk_gate4 ("usb1_ctrl_root_clk" ,"usb_core_ref" , base +0x44d0 ,0 ); - clks[IMX8MQ_CLK_USB2_CTRL_ROOT ] =imx_clk_gate4 ("usb2_ctrl_root_clk" ,"usb_core_ref" , base +0x44e0 ,0 ); + clks[IMX8MQ_CLK_USB1_CTRL_ROOT ] =imx_clk_gate4 ("usb1_ctrl_root_clk" ,"usb_bus" , base +0x44d0 ,0 ); + clks[IMX8MQ_CLK_USB2_CTRL_ROOT ] =imx_clk_gate4 ("usb2_ctrl_root_clk" ,"usb_bus" , base +0x44e0 ,0 ); clks[IMX8MQ_CLK_USB1_PHY_ROOT ] =imx_clk_gate4 ("usb1_phy_root_clk" ,"usb_phy_ref" , base +0x44f0 ,0 ); clks[IMX8MQ_CLK_USB2_PHY_ROOT ] =imx_clk_gate4 ("usb2_phy_root_clk" ,"usb_phy_ref" , base +0x4500 ,0 ); clks[IMX8MQ_CLK_USDHC1_ROOT ] =imx_clk_gate4 ("usdhc1_root_clk" ,"usdhc1" , base +0x4510 ,0 );
Signature · 1 line
2.7.4
PATCH 2/2 arm64: dts: imx8mq: correct usb controller clocks
From: Li Jun <[email protected]>
The correct clock for "bus_early", "ref", "suspend" should be:IMX8MQ_CLK_USB1_CTRL_ROOT, IMX8MQ_CLK_USB_CORE_REF, IMX8MQ_CLK_32K, especially we may need the right suspend clock rate to set register in controller driver.
--- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq.dtsi +4 -4
@@ -901,9 +901,9 @@ usb_dwc3_0: usb@38100000 { compatible = "fsl,imx8mq-dwc3", "snps,dwc3"; reg = <0x38100000 0x10000>; - clocks = <&clk IMX8MQ_CLK_USB_BUS>, + clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>, <&clk IMX8MQ_CLK_USB_CORE_REF>, - <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>; + <&clk IMX8MQ_CLK_32K>; clock-names = "bus_early", "ref", "suspend"; assigned-clocks = <&clk IMX8MQ_CLK_USB_BUS>, <&clk IMX8MQ_CLK_USB_CORE_REF>;
@@ -933,9 +933,9 @@ usb_dwc3_1: usb@38200000 { compatible = "fsl,imx8mq-dwc3", "snps,dwc3"; reg = <0x38200000 0x10000>; - clocks = <&clk IMX8MQ_CLK_USB_BUS>, + clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>, <&clk IMX8MQ_CLK_USB_CORE_REF>, - <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>; + <&clk IMX8MQ_CLK_32K>; clock-names = "bus_early", "ref", "suspend"; assigned-clocks = <&clk IMX8MQ_CLK_USB_BUS>, <&clk IMX8MQ_CLK_USB_CORE_REF>;
Signature · 1 line
2.7.4
Quoted 6 lines · On 19-07-10 19:19:16, [email protected] wrote:
From: Li Jun <[email protected]>
Per latest imx8mq datasheet of CCM, the parent of
usb1_ctrl_root_clkandusb2_ctrl_root_clkisusb_bus.Signed-off-by Li Jun <[email protected]>
For the entire series.
Quoted 22 lines
--- drivers/clk/imx/clk-imx8mq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/clk/imx/clk-imx8mq.c +2
-2@@ -523,8 +523,8 @@ static int imx8mq_clocks_probe(struct platform_device *pdev) clks[IMX8MQ_CLK_UART2_ROOT ] =imx_clk_gate4 ("uart2_root_clk" ,"uart2" , base +0x44a0 ,0 ); clks[IMX8MQ_CLK_UART3_ROOT ] =imx_clk_gate4 ("uart3_root_clk" ,"uart3" , base +0x44b0 ,0 ); clks[IMX8MQ_CLK_UART4_ROOT ] =imx_clk_gate4 ("uart4_root_clk" ,"uart4" , base +0x44c0 ,0 ); - clks[IMX8MQ_CLK_USB1_CTRL_ROOT ] =imx_clk_gate4 ("usb1_ctrl_root_clk" ,"usb_core_ref" , base +0x44d0 ,0 ); - clks[IMX8MQ_CLK_USB2_CTRL_ROOT ] =imx_clk_gate4 ("usb2_ctrl_root_clk" ,"usb_core_ref" , base +0x44e0 ,0 ); + clks[IMX8MQ_CLK_USB1_CTRL_ROOT ] =imx_clk_gate4 ("usb1_ctrl_root_clk" ,"usb_bus" , base +0x44d0 ,0 ); + clks[IMX8MQ_CLK_USB2_CTRL_ROOT ] =imx_clk_gate4 ("usb2_ctrl_root_clk" ,"usb_bus" , base +0x44e0 ,0 ); clks[IMX8MQ_CLK_USB1_PHY_ROOT ] =imx_clk_gate4 ("usb1_phy_root_clk" ,"usb_phy_ref" , base +0x44f0 ,0 ); clks[IMX8MQ_CLK_USB2_PHY_ROOT ] =imx_clk_gate4 ("usb2_phy_root_clk" ,"usb_phy_ref" , base +0x4500 ,0 ); clks[IMX8MQ_CLK_USDHC1_ROOT ] =imx_clk_gate4 ("usdhc1_root_clk" ,"usdhc1" , base +0x4510 ,0 );Signature · 1 line
2.7.4
Shawn Guo
AppliedQuoted 6 lines · On Wed, Jul 10, 2019 at 07:19:16PM +0800, [email protected] wrote:
From: Li Jun <[email protected]>
Per latest imx8mq datasheet of CCM, the parent of
usb1_ctrl_root_clkandusb2_ctrl_root_clkisusb_bus.Signed-off-by Li Jun <[email protected]>
Applied both, thanks.