Remove unused function drm_agp_bind_pages
Subsystems (2)
PATCH 1/1 Remove unused function drm_agp_bind_pages
--- drivers/gpu/drm/drm_agpsupport.c | 43 ---------------------------------------- include/drm/drm_agpsupport.h | 14 ------------- 2 files changed, 57 deletions(-)
drivers/gpu/drm/drm_agpsupport.c +0 -43
@@ -465,46 +465,3 @@ void drm_legacy_agp_clear(struct drm_device *dev) dev->agp->acquired =0 ; dev->agp->enabled =0 ; } - -/** -* Binds a collection of pages into AGP memory at the given offset, returning -* the AGP memory structure containing them. -* -* No reference is held on the pages during this time -- it is up to the -* caller to handle that. -*/ -struct agp_memory * -drm_agp_bind_pages (struct drm_device *dev, -struct page **pages, -unsigned long num_pages, -uint32_t gtt_offset, -u32 type) -{ -struct agp_memory *mem; -int ret, i; - -DRM_DEBUG ("\n" ); - - mem =agp_allocate_memory (dev->agp->bridge, num_pages, - type); -if (mem ==NULL ) { -DRM_ERROR ("Failed to allocate memory for %ld pages\n" , - num_pages); -return NULL ; - } - -for (i =0 ; i < num_pages; i++) - mem->pages[i] = pages[i]; - mem->page_count = num_pages; - - mem->is_flushed = true; - ret =agp_bind_memory (mem, gtt_offset /PAGE_SIZE ); -if (ret !=0 ) { -DRM_ERROR ("Failed to bind AGP memory: %d\n" , ret); -agp_free_memory (mem); -return NULL ; - } - -return mem; -} -EXPORT_SYMBOL (drm_agp_bind_pages);
include/drm/drm_agpsupport.h +0 -14
@@ -31,11 +31,6 @@ struct drm_agp_head {void drm_free_agp (struct agp_memory * handle,int pages);int drm_bind_agp (struct agp_memory * handle,unsigned int start);int drm_unbind_agp (struct agp_memory * handle); -struct agp_memory *drm_agp_bind_pages (struct drm_device *dev, -struct page **pages, -unsigned long num_pages, -uint32_t gtt_offset, -uint32_t type);struct drm_agp_head *drm_agp_init (struct drm_device *dev);void drm_legacy_agp_clear (struct drm_device *dev);
@@ -80,15 +75,6 @@ static inline int drm_unbind_agp(struct agp_memory * handle)return -ENODEV ; } -static inline struct agp_memory *drm_agp_bind_pages (struct drm_device *dev, -struct page **pages, -unsigned long num_pages, -uint32_t gtt_offset, -uint32_t type) -{ -return NULL ; -} -static inline struct drm_agp_head *drm_agp_init (struct drm_device *dev) {return NULL ;
Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Maya.
Nice catch - good to remove unused cruft.
Please prefix the subject with something like "drm/agp: ". Check "git log" on the same file to pick up the usual way to identify agp specific changes.
With this fixed:
You could also consider to add a few words in the body of the changelog how the unused function was identified.
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 8 lines · Sam Ravnborg
Hi Maya.
Nice catch - good to remove unused cruft.
Please prefix the subject with something like "drm/agp: ". Check "git log" on the same file to pick up the usual way to identify agp specific changes.
Quoted 5 lines
With this fixed:
Reviewed-by Sam Ravnborg <[email protected]>You could also consider to add a few words in the body of the changelog how the unused function was identified.
Also needs sob per https://dri.freedesktop.org/docs/drm/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
-Daniel
Quoted 6 lines
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel