Skip to contentSkip to conversation

watchdog: digicolor_wdt: drop unused variable

PATCH In review Arnd Bergmann 3 participants 3 messages Jul 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: digicolor_wdt: drop unused variable

The last cleanup patch left behind an unused variable that should have been removed as well:

drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]

Fixes cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
---
 drivers/watchdog/digicolor_wdt.c | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/digicolor_wdt.c +0 -1
index 33cda95bd238..073d37867f47 100644
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dc_wdt *wdt;
-	int ret;
 
 	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
 	if (!wdt)
Signature · 1 line
2.20.0
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Arnd,

Quoted 7 lines · Arnd Bergmann

The last cleanup patch left behind an unused variable that should have been removed as well:

drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]

Fixes cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")

Thanks,
baruch

Quoted 15 lines
 drivers/watchdog/digicolor_wdt.c | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/digicolor_wdt.c +0 -1
index 33cda95bd238..073d37867f47 100644
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dc_wdt *wdt;
-	int ret;
 
 	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
 	if (!wdt)
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann

The last cleanup patch left behind an unused variable that should have been removed as well:

drivers/watchdog/digicolor_wdt.c:121:6: error: unused variable 'ret' [-Werror,-Wunused-variable]

Fixes cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")

Already submitted as https://patchwork.kernel.org/patch/11037487/ ...

Guenter

Quoted 19 lines
---
 drivers/watchdog/digicolor_wdt.c | 1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/digicolor_wdt.c +0 -1
index 33cda95bd238..073d37867f47 100644
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dc_wdt *wdt;
-	int ret;
 
 	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
 	if (!wdt)
Signature · 1 line
2.20.0