Skip to contentSkip to conversation

phy: Add support for phy-da8xx-usb

PATCH New Adam Ford 2 participants 6 messages Jul 10, 2019 – Jul 21, 2019

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/3 phy: Add support for phy-da8xx-usb

In preparation for supporting the musb driver, this patch adds support for the usb phy associated with the musb driver.

---
 drivers/phy/Kconfig         |  6 ++++
 drivers/phy/Makefile        |  1 +
 drivers/phy/phy-da8xx-usb.c | 64 +++++++++++++++++++++++++++++++++++++
 3 files changed, 71 insertions(+)

V2: Split phy into a separate driver

drivers/phy/Kconfig +6 -0
index 957efb3984..8209ca7323 100644
@@ -84,6 +84,12 @@ config BCM6368_USBH_PHY
 	help
 	  Support for the Broadcom MIPS BCM6368 USBH PHY.
 
+config PHY_DA8XX_USB
+	tristate "TI DA8xx USB PHY Driver"
+	depends on PHY && ARCH_DAVINCI
+	help
+	  Enable this to support the USB PHY on DA8xx SoCs.
+
 config PIPE3_PHY
 	bool "Support omap's PIPE3 PHY"
 	depends on PHY && ARCH_OMAP2PLUS
drivers/phy/Makefile +1 -0
index 90646ca55b..b9f5195e1c 100644
@@ -21,3 +21,4 @@ obj-$(CONFIG_MSM8916_USB_PHY) += msm8916-usbh-phy.o
 obj-$(CONFIG_OMAP_USB2_PHY) += omap-usb2-phy.o
 obj-$(CONFIG_KEYSTONE_USB_PHY) += keystone-usb-phy.o
 obj-$(CONFIG_MT76X8_USB_PHY) += mt76x8-usb-phy.o
+obj-$(CONFIG_PHY_DA8XX_USB) += phy-da8xx-usb.o
drivers/phy/phy-da8xx-usb.c new file +64 -0

64 lines not on this page · raw message

Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 2/3 usb: musb-new: Add support for da8xx-musb

With the recently added phy driver, this patch will enable the musb driver on the da8xx to operate in host mode.

---
 drivers/usb/musb-new/Kconfig  |   8 +
 drivers/usb/musb-new/Makefile |   1 +
 drivers/usb/musb-new/da8xx.c  | 350 ++++++++++++++++++++++++++++++++++
 3 files changed, 359 insertions(+)

V2: Remove poorly formatted comments. Remove dead code. Point to new PHY
driver.

drivers/usb/musb-new/Kconfig +8 -0
index 75005ccdd1..79ad14ef66 100644
@@ -18,6 +18,14 @@ config USB_MUSB_GADGET
 	help
 	  Enables the MUSB USB dual-role controller in gadget mode.
 
+config USB_MUSB_DA8XX
+	bool "Enable DA8xx MUSB Controller"
+	depends on DM_USB
+	help
+	  Say y here to enable support for the dual role high
+	  speed USB controller based on the Mentor Graphics
+	  silicon IP.
+
 config USB_MUSB_TI
 	bool "Enable TI OTG USB controller"
 	depends on DM_USB
drivers/usb/musb-new/Makefile +1 -0
index 4eca0e5631..ec7852ce94 100644
@@ -6,6 +6,7 @@ obj-$(CONFIG_USB_MUSB_GADGET) += musb_gadget.o musb_gadget_ep0.o musb_core.o
 obj-$(CONFIG_USB_MUSB_GADGET) += musb_uboot.o
 obj-$(CONFIG_USB_MUSB_HOST) += musb_host.o musb_core.o musb_uboot.o
 obj-$(CONFIG_USB_MUSB_DSPS) += musb_dsps.o
+obj-$(CONFIG_USB_MUSB_DA8XX)	+= da8xx.o
 obj-$(CONFIG_USB_MUSB_AM35X) += am35x.o
 obj-$(CONFIG_USB_MUSB_OMAP2PLUS) += omap2430.o
 obj-$(CONFIG_USB_MUSB_PIC32) += pic32.o
drivers/usb/musb-new/da8xx.c new file +350 -0

350 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/3 usb: musb-new: Add support for da8xx-musb

Quoted 9 lines · Adam Ford

With the recently added phy driver, this patch will enable the musb driver on the da8xx to operate in host mode.

---
 drivers/usb/musb-new/Kconfig  |   8 +
 drivers/usb/musb-new/Makefile |   1 +
 drivers/usb/musb-new/da8xx.c  | 350 ++++++++++++++++++++++++++++++++++
 3 files changed, 359 insertions(+)

Much better,

author
#3 lore raw

PATCH v2 2/3 usb: musb-new: Add support for da8xx-musb

Quoted 5 lines · Marek Vasut
Quoted 3 lines · Adam Ford

With the recently added phy driver, this patch will enable the musb driver on the da8xx to operate in host mode.

Quoted 8 lines
Quoted 6 lines
---
 drivers/usb/musb-new/Kconfig  |   8 +
 drivers/usb/musb-new/Makefile |   1 +
 drivers/usb/musb-new/da8xx.c  | 350 ++++++++++++++++++++++++++++++++++
 3 files changed, 359 insertions(+)

Much better,

Does that mean it's good enough to apply? ;-)

adam

Quoted 2 lines
#4 lore raw

PATCH v2 2/3 usb: musb-new: Add support for da8xx-musb

Quoted 13 lines · Adam Ford
Quoted 12 lines · Marek Vasut
Quoted 9 lines · Adam Ford

With the recently added phy driver, this patch will enable the musb driver on the da8xx to operate in host mode.

---
 drivers/usb/musb-new/Kconfig  |   8 +
 drivers/usb/musb-new/Makefile |   1 +
 drivers/usb/musb-new/da8xx.c  | 350 ++++++++++++++++++++++++++++++++++
 3 files changed, 359 insertions(+)
Quoted 3 lines
Quoted 1 line

Much better,

Does that mean it's good enough to apply? ;-)

Yes, applied all, thanks.

author
#5 lore raw

PATCH v2 3/3 ARM: da850-evm: Enable the USB PHY and MUSB Driver

In reply to Adam Ford

This patch will enable the MUSB driver to support mass storage devices connected to the OTG port in host mode.

---
 configs/da850evm_defconfig            | 6 ++++++
 configs/da850evm_direct_nor_defconfig | 6 ++++++
 configs/da850evm_nand_defconfig       | 6 ++++++
 include/configs/da850evm.h            | 3 ---
 4 files changed, 18 insertions(+), 3 deletions(-)

V2: Split off adding the da850evm configs until all other drivers have been added

configs/da850evm_defconfig +6 -0
index c095058282..4e8d122752 100644
@@ -61,6 +61,8 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_SPI_FLASH_MTD=y
 CONFIG_MII=y
 CONFIG_DRIVER_TI_EMAC=y
+CONFIG_PHY=y
+CONFIG_PHY_DA8XX_USB=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_DM_SERIAL=y
@@ -73,5 +75,9 @@ CONFIG_DM_USB=y
 # CONFIG_SPL_DM_USB is not set
 CONFIG_USB_OHCI_HCD=y
 CONFIG_USB_OHCI_DA8XX=y
+CONFIG_USB_MUSB_HOST=y
+CONFIG_USB_MUSB_DA8XX=y
+CONFIG_USB_MUSB_PIO_ONLY=y
+CONFIG_USB_STORAGE=y
 # CONFIG_FAT_WRITE is not set
 CONFIG_USE_TINY_PRINTF=y
configs/da850evm_direct_nor_defconfig +6 -0
index 166e77b8e3..412a6d69a2 100644
@@ -52,6 +52,8 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_MII=y
 CONFIG_DRIVER_TI_EMAC=y
+CONFIG_PHY=y
+CONFIG_PHY_DA8XX_USB=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_SPECIFY_CONSOLE_INDEX=y
@@ -60,3 +62,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_DAVINCI_SPI=y
+CONFIG_USB_MUSB_HOST=y
+CONFIG_USB_MUSB_DA8XX=y
+CONFIG_USB_MUSB_PIO_ONLY=y
+CONFIG_USB_STORAGE=y
configs/da850evm_nand_defconfig +6 -0
index 7271016346..17a901587a 100644
@@ -59,6 +59,8 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_SPI_FLASH_MTD=y
+CONFIG_PHY=y
+CONFIG_PHY_DA8XX_USB=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_DM_SERIAL=y
@@ -66,5 +68,9 @@ CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_DAVINCI_SPI=y
+CONFIG_USB_MUSB_HOST=y
+CONFIG_USB_MUSB_DA8XX=y
+CONFIG_USB_MUSB_PIO_ONLY=y
+CONFIG_USB_STORAGE=y
 # CONFIG_FAT_WRITE is not set
 CONFIG_USE_TINY_PRINTF=y
include/configs/da850evm.h +0 -3
index ccdac0abec..855deb5f94 100644
@@ -270,10 +270,7 @@
 /* USB Configs */
 #define CONFIG_SYS_USB_OHCI_CPU_INIT
 #define CONFIG_USB_OHCI_NEW
-#define CONFIG_USB_STORAGE
-#define CONFIG_SYS_USB_OHCI_REGS_BASE		0x01E25000
 #define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS	15
-#define CONFIG_SYS_USB_OHCI_SLOT_NAME		"da850evm"
 
 #ifndef CONFIG_DIRECT_NOR_BOOT
 /* defines for SPL */
Signature · 1 line
2.17.1