Skip to contentSkip to conversation

migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()

PATCH In review Wei Yang 2 participants 4 messages Jul 11, 2019 – Aug 7, 2019

lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH 1/1 migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()

PostcopyState is already set to ADVISE at the beginning of loadvm_postcopy_handle_advise().

Remove the redundant set.

---
 migration/savevm.c | 2 --
 1 file changed, 2 deletions(-)
migration/savevm.c +0 -2
index 8a2ada529e..2350e219fc 100644
@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
         return -1;
     }
 
-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
-
     return 0;
 }
 
Signature · 1 line
2.17.1
author
#1 lore raw
Quoted 4 lines · Wei Yang

PostcopyState is already set to ADVISE at the beginning of loadvm_postcopy_handle_advise().

Remove the redundant set.

Ping~

Quoted 21 lines

---
migration/savevm.c | 2 --

1 file changed, 2 deletions(-)
migration/savevm.c +0 -2
index 8a2ada529e..2350e219fc 100644
@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
        return -1;
    }
 
-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
-
    return 0;
 }
 
Signature · 1 line
2.17.1
Signature · 2 lines
Wei Yang
Help you, Help me
Reviewed-by on v1 1/1
#2 lore raw
In reply to Wei Yang
Quoted 6 lines · * Wei Yang ([email protected]) wrote:

PostcopyState is already set to ADVISE at the beginning of loadvm_postcopy_handle_advise().

Remove the redundant set.

Quoted 20 lines
---
 migration/savevm.c | 2 --
 1 file changed, 2 deletions(-)
migration/savevm.c +0 -2
index 8a2ada529e..2350e219fc 100644
@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
         return -1;
     }
 
-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
-
     return 0;
 }
 
Signature · 1 line
2.17.1

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

#3 lore raw
In reply to Wei Yang
Quoted 6 lines · * Wei Yang ([email protected]) wrote:

PostcopyState is already set to ADVISE at the beginning of loadvm_postcopy_handle_advise().

Remove the redundant set.

Queued

Quoted 21 lines
---
 migration/savevm.c | 2 --
 1 file changed, 2 deletions(-)
migration/savevm.c +0 -2
index 8a2ada529e..2350e219fc 100644
@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
         return -1;
     }
 
-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
-
     return 0;
 }
 
Signature · 1 line
2.17.1

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK