drm/bridge: ti-sn65dsi86: use dev name for debugfs
Subsystems (5)
PATCH 1/1 drm/bridge: ti-sn65dsi86: use dev name for debugfs
From: Rob Clark <[email protected]>
This should be more future-proof if we ever encounter a device with two of these bridges.
--- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/ti-sn65dsi86.c +1 -1
@@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);static void ti_sn_debugfs_init (struct ti_sn_bridge *pdata) { - pdata->debugfs =debugfs_create_dir ("ti_sn65dsi86" ,NULL ); + pdata->debugfs =debugfs_create_dir (dev_name (pdata->dev),NULL );debugfs_create_file ("status" ,0600 , pdata->debugfs, pdata, &status_fops);
Signature · 1 line
2.20.1
Quoted 7 lines · Rob Clark
From: Rob Clark <[email protected]>
This should be more future-proof if we ever encounter a device with two of these bridges.
Suggested-by Laurent Pinchart <[email protected]>Signed-off-by Rob Clark <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/ti-sn65dsi86.c +1
-1@@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);static void ti_sn_debugfs_init (struct ti_sn_bridge *pdata) { - pdata->debugfs =debugfs_create_dir ("ti_sn65dsi86" ,NULL ); + pdata->debugfs =debugfs_create_dir (dev_name (pdata->dev),NULL );debugfs_create_file ("status" ,0600 , pdata->debugfs, pdata, &status_fops);Signature · 1 line
2.20.1
Laurent Pinchart
reviewerHi Rob,
Thank you for the patch.
Quoted 16 lines · Rob Clark
From: Rob Clark <[email protected]>
This should be more future-proof if we ever encounter a device with two of these bridges.
Suggested-by Laurent Pinchart <[email protected]>Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/ti-sn65dsi86.c +0
-0
drivers/gpu/drm/bridge/ti-sn65dsi86.c DEFINE_SHOW_ATTRIBUTE(status); · line 207
Quoted 5 lines
drivers/gpu/drm/bridge/ti-sn65dsi86.c +1
-1@@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);static void ti_sn_debugfs_init (struct ti_sn_bridge *pdata) { - pdata->debugfs =debugfs_create_dir ("ti_sn65dsi86" ,NULL ); + pdata->debugfs =debugfs_create_dir (dev_name (pdata->dev),NULL );
That should work, but won't it become quite confusing for users ? I wonder if the directory name shouldn't be prefixed with the driver name. Something like "ti_sn65dsi86:%s", dev_name(pdata->dev).
Quoted 2 lines
drivers/gpu/drm/bridge/ti-sn65dsi86.c +0
-0debugfs_create_file ("status" ,0600 , pdata->debugfs, pdata, &status_fops);
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 23 lines · Laurent Pinchart
Hi Rob,
Thank you for the patch.
Quoted 17 lines · Rob Clark
From: Rob Clark <[email protected]>
This should be more future-proof if we ever encounter a device with two of these bridges.
Suggested-by Laurent Pinchart <[email protected]>Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/ti-sn65dsi86.c +0
-0@@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
Quoted 8 lines
drivers/gpu/drm/bridge/ti-sn65dsi86.c DEFINE_SHOW_ATTRIBUTE(status); · line 207
Quoted 4 lines
drivers/gpu/drm/bridge/ti-sn65dsi86.c +1
-1static void ti_sn_debugfs_init (struct ti_sn_bridge *pdata) { - pdata->debugfs =debugfs_create_dir ("ti_sn65dsi86" ,NULL ); + pdata->debugfs =debugfs_create_dir (dev_name (pdata->dev),NULL );That should work, but won't it become quite confusing for users ? I wonder if the directory name shouldn't be prefixed with the driver name. Something like "ti_sn65dsi86:%s",
dev_name(pdata->dev).
*maybe*, if they are badly named in dt? In the end the target audience is really to help developers and people bringing up a new board, so maybe my way encourages them to use sensible names in dt ;-)
BR,
-R
Quoted 8 lines
drivers/gpu/drm/bridge/ti-sn65dsi86.c DEFINE_SHOW_ATTRIBUTE(status); · line 210
Quoted 3 lines
drivers/gpu/drm/bridge/ti-sn65dsi86.c +0
-0debugfs_create_file ("status" ,0600 , pdata->debugfs, pdata, &status_fops);--
Regards,Laurent Pinchart
Andrzej Hajda
AppliedQuoted 7 lines · Rob Clark
From: Rob Clark <[email protected]>
This should be more future-proof if we ever encounter a device with two of these bridges.
Suggested-by Laurent Pinchart <[email protected]>Signed-off-by Rob Clark <[email protected]>
Queued to drm-misc-next.
Regards
Andrzej