xio3130_downstream: typo fix
PATCH 1/1 xio3130_downstream: typo fix
slt ctl/status are passed in incorrect order.
Fix this up.
Signed-off-by Michael S. Tsirkin <[email protected]>
Reported-by Peter Maydell <[email protected]>
--- hw/pci-bridge/xio3130_downstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/pci-bridge/xio3130_downstream.c +1 -1
@@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address, {uint16_t slt_ctl, slt_sta; -pcie_cap_slot_get (d, &slt_sta, &slt_ctl); +pcie_cap_slot_get (d, &slt_ctl, &slt_sta);pci_bridge_write_config (d, address, val, len);pcie_cap_flr_write_config (d, address, val, len);pcie_cap_slot_write_config (d, slt_ctl, slt_sta, address, val, len);
Signature · 1 line
MST
Quoted 14 lines · Michael S. Tsirkin
slt ctl/status are passed in incorrect order.
Fix this up.Signed-off-by Michael S. Tsirkin <[email protected]>Reported-by Peter Maydell <[email protected]>--- hw/pci-bridge/xio3130_downstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/pci-bridge/xio3130_downstream.c +0
-0
hw/pci-bridge/xio3130_downstream.c static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address, · line 49
Quoted 8 lines
hw/pci-bridge/xio3130_downstream.c +1
-1@@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address, {uint16_t slt_ctl, slt_sta; -pcie_cap_slot_get (d, &slt_sta, &slt_ctl); +pcie_cap_slot_get (d, &slt_ctl, &slt_sta);pci_bridge_write_config (d, address, val, len);pcie_cap_flr_write_config (d, address, val, len);pcie_cap_slot_write_config (d, slt_ctl, slt_sta, address, val, len);
Reviewed-by Marcel Apfelbaum <[email protected]>
Thanks,
Marcel
Quoted 3 lines · Michael S. Tsirkin
slt ctl/status are passed in incorrect order.
Fix this up.
Fixes Coverity (CID 1403007)
Quoted 20 lines
Signed-off-by Michael S. Tsirkin <[email protected]>Reported-by Peter Maydell <[email protected]>--- hw/pci-bridge/xio3130_downstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/pci-bridge/xio3130_downstream.c +1
-1@@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address, {uint16_t slt_ctl, slt_sta; -pcie_cap_slot_get (d, &slt_sta, &slt_ctl); +pcie_cap_slot_get (d, &slt_ctl, &slt_sta);pci_bridge_write_config (d, address, val, len);pcie_cap_flr_write_config (d, address, val, len);pcie_cap_slot_write_config (d, slt_ctl, slt_sta, address, val, len);