Skip to contentSkip to conversation

ninja: use Python 3

PATCH In review Ross Burton 2 participants 5 messages Jul 11, 2019 – Jul 12, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ninja: use Python 3

As part of the mission to remove the use of Python 2, explicitly bootstrap Ninja with Python 3.

---
 meta/recipes-devtools/ninja/ninja_1.9.0.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/ninja/ninja_1.9.0.bb +2 -2
index 1b063289614..f1236e8ac82 100644
@@ -17,11 +17,11 @@ S = "${WORKDIR}/git"
 do_configure[noexec] = "1"
 
 do_compile_class-native() {
-	./configure.py --bootstrap
+	python3 ./configure.py --bootstrap
 }
 
 do_compile() {
-	./configure.py
+	python3 ./configure.py
 	ninja
 }
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 14 lines · Ross Burton

As part of the mission to remove the use of Python 2, explicitly bootstrap Ninja with Python 3.

---
 meta/recipes-devtools/ninja/ninja_1.9.0.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/ninja/ninja_1.9.0.bb +0 -0
index 1b063289614..f1236e8ac82 100644

meta/recipes-devtools/ninja/ninja_1.9.0.bb S = "${WORKDIR}/git" · line 24

Quoted 10 lines
meta/recipes-devtools/ninja/ninja_1.9.0.bb +2 -2
@@ -17,11 +17,11 @@ S = "${WORKDIR}/git"
 do_configure[noexec] = "1"
 
 do_compile_class-native() {
-       ./configure.py --bootstrap
+       python3 ./configure.py --bootstrap
 }
 
 do_compile() {
-       ./configure.py
+       python3 ./configure.py

Maybe we should encode it in interpreter section inside configure.py itself and upstream it.

Quoted 11 lines
meta/recipes-devtools/ninja/ninja_1.9.0.bb +0 -1
        ninja
 }
 
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Bug closed as 'python' doesn't have to mean Python 2. We'll use use python3 to start the bootstrap ourself.

Quoted 10 lines · Ross
Quoted 2 lines · Khem Raj

Maybe we should encode it in interpreter section inside configure.py itself and upstream it.

I've filed a bug (https://github.com/ninja-build/ninja/issues/1601) to see if they have any strong reasons to stick with python instead of python3.

Ross

#4 lore raw
In reply to Burton, Ross
Quoted 8 lines · Ross
Quoted 2 lines · Khem Raj

Maybe we should encode it in interpreter section inside configure.py itself and upstream it.

I've filed a bug (https://github.com/ninja-build/ninja/issues/1601) to see if they have any strong reasons to stick with python instead of python3.

OK so they are oblivious to python version which is great, I wish whole python world was like that

Quoted 2 lines

Ross