ASoC: audio-graph-card: Constify reg in graph_get_dai_id
PATCH 1/1 ASoC: audio-graph-card: Constify reg in graph_get_dai_id
clang errors:
sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *' (aka 'unsigned int *') from 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
reg = of_get_property(node, "reg", NULL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~1 error generated.
Move the declaration up a bit to keep the reverse christmas tree look.
--- sound/soc/generic/audio-graph-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/generic/audio-graph-card.c +1 -1
@@ -62,8 +62,8 @@ static int graph_get_dai_id(struct device_node *ep)struct device_node *node;struct device_node *endpoint;struct of_endpoint info; +const u32 *reg;int i, id; -u32 *reg;int ret;/* use driver specified DAI ID if exist */
Signature · 1 line
2.22.0
PATCH v2 1/1 ASoC: audio-graph-card: Constify reg in graph_get_dai_id
clang errors:
sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *' (aka 'unsigned int *') from 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
reg = of_get_property(node, "reg", NULL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~1 error generated.
Move the declaration up a bit to keep the reverse christmas tree look.
---
v1 -> v2:
* Update link in commit message (sorry, I create the commit message and send the patch first then create the issue and I forgot to check the closed ones for the correct number)
sound/soc/generic/audio-graph-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/generic/audio-graph-card.c +1 -1
@@ -62,8 +62,8 @@ static int graph_get_dai_id(struct device_node *ep)struct device_node *node;struct device_node *endpoint;struct of_endpoint info; +const u32 *reg;int i, id; -u32 *reg;int ret;/* use driver specified DAI ID if exist */
Signature · 1 line
2.22.0
Kuninori Morimoto
maintainerHi Nathan
Quoted 7 lines
clang errors:
sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *' (aka 'unsigned int *') from 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]reg = of_get_property(node, "reg", NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 8 lines
1 error generated.
Move the declaration up a bit to keep the reverse christmas tree look.
Fixes c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")Signed-off-by Nathan Chancellor <[email protected]>---
Maybe
ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc
("ASoC: audio-graph-card: add missing const at graph_get_dai_id()")
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Quoted 21 lines · Kuninori Morimoto
Hi Nathan
Quoted 7 lines
clang errors:
sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *' (aka 'unsigned int *') from 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]reg = of_get_property(node, "reg", NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Quoted 8 lines
1 error generated.
Move the declaration up a bit to keep the reverse christmas tree look.
Fixes c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")Signed-off-by Nathan Chancellor <[email protected]>---
Maybe
Quoted 7 lines
ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc
("ASoC: audio-graph-card: add missing const atgraph_get_dai_id()")Thank you for your help !!
Best regards
---
Kuninori Morimoto
Ugh, I even checked Mark's tree before sending this, just completely glossed over that patch. Sorry for the noise :(
Cheers,
Nathan