Skip to contentSkip to conversation

staging: erofs: Remove function erofs_kill_sb()

PATCH New Nishka Dasgupta 3 participants 3 messages Jul 12, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: erofs: Remove function erofs_kill_sb()

Remove function erofs_kill_sb as all it does is call kill_block_super. Modify references to the former to point to the latter. Issue found with Coccinelle.

Signed-off-by Nishka Dasgupta <nishkadg.linux at gmail.com>
---
 drivers/staging/erofs/super.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/staging/erofs/super.c +1 -6
index 54494412eba4..3e2a65ba1945 100644
@@ -554,16 +554,11 @@ static struct dentry *erofs_mount(
 		&priv, erofs_fill_super);
 }
 
-static void erofs_kill_sb(struct super_block *sb)
-{
-	kill_block_super(sb);
-}
-
 static struct file_system_type erofs_fs_type = {
 	.owner          = THIS_MODULE,
 	.name           = "erofs",
 	.mount          = erofs_mount,
-	.kill_sb        = erofs_kill_sb,
+	.kill_sb        = kill_block_super,
 	.fs_flags       = FS_REQUIRES_DEV,
 };
 MODULE_ALIAS_FS("erofs");
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 staging: erofs: Remove function erofs_kill_sb()

Quoted 5 lines · Nishka Dasgupta

Remove function erofs_kill_sb as all it does is call kill_block_super. Modify references to the former to point to the latter. Issue found with Coccinelle.

Signed-off-by Nishka Dasgupta <nishkadg.linux at gmail.com>
Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>

Thanks,
Gao Xiang

#2 lore raw

PATCH 1/1 staging: erofs: Remove function erofs_kill_sb()

In reply to Nishka Dasgupta
Quoted 5 lines · Nishka Dasgupta

Remove function erofs_kill_sb as all it does is call kill_block_super. Modify references to the former to point to the latter. Issue found with Coccinelle.

Signed-off-by Nishka Dasgupta <nishkadg.linux at gmail.com>
Reviewed-by Chao Yu <yuchao0 at huawei.com>

Thanks,