Skip to contentSkip to conversation

slab: work around clang bug #42570

PATCH In review Arnd Bergmann 2 participants 2 messages Jul 12, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 slab: work around clang bug #42570

Clang gets rather confused about two variables in the same special section when one of them is not initialized, leading to an assembler warning later:

/tmp/slab_common-18f869.s: Assembler messages:
/tmp/slab_common-18f869.s:7526: Warning: ignoring changed section attributes for .data..ro_after_init

Adding an initialization to kmalloc_caches is rather silly here but does avoid the issue.

---
We might decide to wait until this is fixed in clang, but so far all versions targetting x86 seem to be affected.

---
 mm/slab_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/slab_common.c +2 -1
index 6c49dbb3769e..807490fe217a 100644
@@ -1028,7 +1028,8 @@ struct kmem_cache *__init create_kmalloc_cache(const char *name,
 }
 
 struct kmem_cache *
-kmalloc_caches[NR_KMALLOC_TYPES][KMALLOC_SHIFT_HIGH + 1] __ro_after_init;
+kmalloc_caches[NR_KMALLOC_TYPES][KMALLOC_SHIFT_HIGH + 1] __ro_after_init =
+{ /* initialization for https://bugs.llvm.org/show_bug.cgi?id=42570 */ };
 EXPORT_SYMBOL(kmalloc_caches);
 
 /*
Signature · 1 line
2.20.0
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Arnd Bergmann

Clang gets rather confused about two variables in the same special section when one of them is not initialized, leading to an assembler warning later:

Quoted 8 lines

/tmp/slab_common-18f869.s: Assembler messages:
/tmp/slab_common-18f869.s:7526: Warning: ignoring changed section attributes for .data..ro_after_init

Adding an initialization to kmalloc_caches is rather silly here but does avoid the issue.

Let me followup on the clang bug as well.