Skip to contentSkip to conversation

mx6: clock: Allow enable_ipu_clock() to be built for SPL code

PATCH New Fabio Estevam 3 participants 15 messages Jul 12, 2019 – Nov 4, 2019

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/4 mx6: clock: Allow enable_ipu_clock() to be built for SPL code

Allow enable_ipu_clock() to be built for SPL code. This is done in preparation for configuring the NoC registers on i.MX6QP in SPL.

---
 arch/arm/mach-imx/mx6/clock.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
arch/arm/mach-imx/mx6/clock.c +16 -16
index 366a4e3c6b..5af1ae7cf3 100644
@@ -1275,6 +1275,22 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
 	return 0;
 }
 
+#ifndef CONFIG_MX6SX
+void enable_ipu_clock(void)
+{
+	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
+	int reg;
+	reg = readl(&mxc_ccm->CCGR3);
+	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
+	writel(reg, &mxc_ccm->CCGR3);
+
+	if (is_mx6dqp()) {
+		setbits_le32(&mxc_ccm->CCGR6, MXC_CCM_CCGR6_PRG_CLK0_MASK);
+		setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU2_IPU_MASK);
+	}
+}
+#endif
+
 #ifndef CONFIG_SPL_BUILD
 /*
  * Dump some core clockes.
@@ -1311,22 +1327,6 @@ int do_mx6_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	return 0;
 }
 
-#ifndef CONFIG_MX6SX
-void enable_ipu_clock(void)
-{
-	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
-	int reg;
-	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
-	writel(reg, &mxc_ccm->CCGR3);
-
-	if (is_mx6dqp()) {
-		setbits_le32(&mxc_ccm->CCGR6, MXC_CCM_CCGR6_PRG_CLK0_MASK);
-		setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU2_IPU_MASK);
-	}
-}
-#endif
-
 #if defined(CONFIG_MX6Q) || defined(CONFIG_MX6D) || defined(CONFIG_MX6DL) || \
 	defined(CONFIG_MX6S)
 static void disable_ldb_di_clock_sources(void)
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 1/4 mx6: clock: Allow enable_ipu_clock() to be built for SPL code

Hi Stefano,

Could this series be applied, please?

Quoted 62 lines · Fabio Estevam

Allow enable_ipu_clock() to be built for SPL code. This is done in preparation for configuring the NoC registers on i.MX6QP in SPL.

---
 arch/arm/mach-imx/mx6/clock.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
arch/arm/mach-imx/mx6/clock.c +16 -17
index 366a4e3c6b..5af1ae7cf3 100644
@@ -1275,6 +1275,22 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
        return 0;
 }
 
+#ifndef CONFIG_MX6SX
+void enable_ipu_clock(void)
+{
+       struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
+       int reg;
+       reg = readl(&mxc_ccm->CCGR3);
+       reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
+       writel(reg, &mxc_ccm->CCGR3);
+
+       if (is_mx6dqp()) {
+               setbits_le32(&mxc_ccm->CCGR6, MXC_CCM_CCGR6_PRG_CLK0_MASK);
+               setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU2_IPU_MASK);
+       }
+}
+#endif
+
 #ifndef CONFIG_SPL_BUILD
 /*
  * Dump some core clockes.
@@ -1311,22 +1327,6 @@ int do_mx6_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
        return 0;
 }
 
-#ifndef CONFIG_MX6SX
-void enable_ipu_clock(void)
-{
-       struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
-       int reg;
-       reg = readl(&mxc_ccm->CCGR3);
-       reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
-       writel(reg, &mxc_ccm->CCGR3);
-
-       if (is_mx6dqp()) {
-               setbits_le32(&mxc_ccm->CCGR6, MXC_CCM_CCGR6_PRG_CLK0_MASK);
-               setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU2_IPU_MASK);
-       }
-}
-#endif
-
 #if defined(CONFIG_MX6Q) || defined(CONFIG_MX6D) || defined(CONFIG_MX6DL) || \
        defined(CONFIG_MX6S)
 static void disable_ldb_di_clock_sources(void)
--

2.17.1

author reviewer
#2 lore raw

PATCH 2/4 mx6: clock: Use setbits_le32()

In reply to Fabio Estevam

The code can be made simpler by using setbits_le32(), so switch to it.

---
 arch/arm/mach-imx/mx6/clock.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/arm/mach-imx/mx6/clock.c +2 -4
index 5af1ae7cf3..9951f79106 100644
@@ -1279,10 +1279,8 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
 void enable_ipu_clock(void)
 {
 	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
-	int reg;
-	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
-	writel(reg, &mxc_ccm->CCGR3);
+
+	setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU1_IPU_MASK);
 
 	if (is_mx6dqp()) {
 		setbits_le32(&mxc_ccm->CCGR6, MXC_CCM_CCGR6_PRG_CLK0_MASK);
Signature · 1 line
2.17.1
#3 lore raw

PATCH 2/4 mx6: clock: Use setbits_le32()

Quoted 26 lines

Subject: [PATCH 2/4] mx6: clock: Use setbits_le32()

The code can be made simpler by using setbits_le32(), so switch to it.

---
 arch/arm/mach-imx/mx6/clock.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-imx/mx6/clock.c index 5af1ae7cf3..9951f79106 100644

arch/arm/mach-imx/mx6/clock.c +2 -4
@@ -1279,10 +1279,8 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
 void enable_ipu_clock(void)  {
 	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg
 *)CCM_BASE_ADDR;
-	int reg;
-	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
-	writel(reg, &mxc_ccm->CCGR3);
+
+	setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU1_IPU_MASK);
 
 	if (is_mx6dqp()) {
 		setbits_le32(&mxc_ccm->CCGR6,
Quoted 1 line

MXC_CCM_CCGR6_PRG_CLK0_MASK);

Quoted 2 lines

--
2.17.1

author reviewer
#4 lore raw

PATCH 3/4 mx6: clock: Introduce disable_ipu_clock()

In reply to Fabio Estevam

Introduce disable_ipu_clock(). This is done in preparation for configuring the NoC registers on i.MX6QP in SPL.

Afer the NoC registers are set the IPU clocks can be disabled.

---
 arch/arm/include/asm/arch-mx6/clock.h |  1 +
 arch/arm/mach-imx/mx6/clock.c         | 12 ++++++++++++
 2 files changed, 13 insertions(+)
arch/arm/include/asm/arch-mx6/clock.h +1 -0
index a9481a5fea..f7760541a4 100644
@@ -71,6 +71,7 @@ int enable_pcie_clock(void);
 int enable_i2c_clk(unsigned char enable, unsigned i2c_num);
 int enable_spi_clk(unsigned char enable, unsigned spi_num);
 void enable_ipu_clock(void);
+void disable_ipu_clock(void);
 int enable_fec_anatop_clock(int fec_id, enum enet_freq freq);
 void enable_enet_clk(unsigned char enable);
 int enable_lcdif_clock(u32 base_addr, bool enable);
arch/arm/mach-imx/mx6/clock.c +12 -0
index 9951f79106..e1e21e37a8 100644
@@ -1287,6 +1287,18 @@ void enable_ipu_clock(void)
 		setbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU2_IPU_MASK);
 	}
 }
+
+void disable_ipu_clock(void)
+{
+	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
+
+	clrbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU1_IPU_MASK);
+
+	if (is_mx6dqp()) {
+		clrbits_le32(&mxc_ccm->CCGR6, MXC_CCM_CCGR6_PRG_CLK0_MASK);
+		clrbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU2_IPU_MASK);
+	}
+}
 #endif
 
 #ifndef CONFIG_SPL_BUILD
Signature · 1 line
2.17.1
#5 lore raw

PATCH 3/4 mx6: clock: Introduce disable_ipu_clock()

Quoted 47 lines

Subject: [PATCH 3/4] mx6: clock: Introduce disable_ipu_clock()

Introduce disable_ipu_clock(). This is done in preparation for configuring the NoC registers on i.MX6QP in SPL.

Afer the NoC registers are set the IPU clocks can be disabled.

---
 arch/arm/include/asm/arch-mx6/clock.h |  1 +
 arch/arm/mach-imx/mx6/clock.c         | 12 ++++++++++++
 2 files changed, 13 insertions(+)
arch/arm/include/asm/arch-mx6/clock.h +0 -0
index a9481a5fea..f7760541a4 100644
@@ -71,6 +71,7 @@ int enable_pcie_clock(void);  int

enable_i2c_clk(unsigned char enable, unsigned i2c_num); int enable_spi_clk(unsigned char enable, unsigned spi_num); void enable_ipu_clock(void);
+void disable_ipu_clock(void);
int enable_fec_anatop_clock(int fec_id, enum enet_freq freq); void
enable_enet_clk(unsigned char enable); int enable_lcdif_clock(u32 base_addr, bool enable); diff --git a/arch/arm/mach-imx/mx6/clock.c b/arch/arm/mach-imx/mx6/clock.c index 9951f79106..e1e21e37a8 100644

arch/arm/mach-imx/mx6/clock.c +10 -0
@@ -1287,6 +1287,18 @@ void enable_ipu_clock(void)
 		setbits_le32(&mxc_ccm->CCGR3,
 MXC_CCM_CCGR3_IPU2_IPU_MASK);
 	}
 }
+
+void disable_ipu_clock(void)
+{
+	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg
 *)CCM_BASE_ADDR;
+
+	clrbits_le32(&mxc_ccm->CCGR3, MXC_CCM_CCGR3_IPU1_IPU_MASK);
+
+	if (is_mx6dqp()) {
+		clrbits_le32(&mxc_ccm->CCGR6,
 MXC_CCM_CCGR6_PRG_CLK0_MASK);
+		clrbits_le32(&mxc_ccm->CCGR3,

MXC_CCM_CCGR3_IPU2_IPU_MASK);

arch/arm/mach-imx/mx6/clock.c void enable_ipu_clock(void) · line 1302

Quoted 3 lines
arch/arm/mach-imx/mx6/clock.c +2 -0
+	}
+}
 #endif
Quoted 4 lines

#ifndef CONFIG_SPL_BUILD
--
2.17.1

#6 lore raw

PATCH 1/4 mx6: clock: Allow enable_ipu_clock() to be built for SPL code

In reply to Fabio Estevam
Quoted 66 lines

Subject: [PATCH 1/4] mx6: clock: Allow enable_ipu_clock() to be built for SPL code

Allow enable_ipu_clock() to be built for SPL code. This is done in preparation for configuring the NoC registers on i.MX6QP in SPL.

---
 arch/arm/mach-imx/mx6/clock.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-imx/mx6/clock.c index 366a4e3c6b..5af1ae7cf3 100644

arch/arm/mach-imx/mx6/clock.c +16 -0
@@ -1275,6 +1275,22 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
 	return 0;
 }
 
+#ifndef CONFIG_MX6SX
+void enable_ipu_clock(void)
+{
+	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg
 *)CCM_BASE_ADDR;
+	int reg;
+	reg = readl(&mxc_ccm->CCGR3);
+	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
+	writel(reg, &mxc_ccm->CCGR3);
+
+	if (is_mx6dqp()) {
+		setbits_le32(&mxc_ccm->CCGR6,
 MXC_CCM_CCGR6_PRG_CLK0_MASK);
+		setbits_le32(&mxc_ccm->CCGR3,
 MXC_CCM_CCGR3_IPU2_IPU_MASK);
+	}
+}
+#endif
+

#ifndef CONFIG_SPL_BUILD
/*
* Dump some core clockes.

arch/arm/mach-imx/mx6/clock.c +0 -12
@@ -1311,22 +1327,6 @@ int do_mx6_showclocks(cmd_tbl_t *cmdtp, int
 flag, int argc, char * const argv[])
 	return 0;
 }
 
-#ifndef CONFIG_MX6SX
-void enable_ipu_clock(void)
-{
-	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg
 *)CCM_BASE_ADDR;
-	int reg;
-	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
-	writel(reg, &mxc_ccm->CCGR3);
-
-	if (is_mx6dqp()) {
-		setbits_le32(&mxc_ccm->CCGR6,
 MXC_CCM_CCGR6_PRG_CLK0_MASK);
-		setbits_le32(&mxc_ccm->CCGR3,

MXC_CCM_CCGR3_IPU2_IPU_MASK);

arch/arm/mach-imx/mx6/clock.c +0 -4
-	}
-}
-#endif
-
 #if defined(CONFIG_MX6Q) || defined(CONFIG_MX6D) ||
Quoted 3 lines

defined(CONFIG_MX6DL) || \
defined(CONFIG_MX6S)
static void disable_ldb_di_clock_sources(void)

Quoted 2 lines

--
2.17.1

author reviewer
#7 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

In reply to Fabio Estevam

The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.

Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.

---
 arch/arm/mach-imx/mx6/soc.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/mach-imx/mx6/soc.c +32 -0
index e80f1d484b..8de42408c7 100644
@@ -365,6 +365,35 @@ static void init_bandgap(void)
 	}
 }
 
+static void noc_setup(void)
+{
+	enable_ipu_clock();
+
+	writel(0x80000201, 0xbb0608);
+	/* Bypass IPU1 QoS generator */
+	writel(0x00000002, 0x00bb048c);
+	/* Bypass IPU2 QoS generator */
+	writel(0x00000002, 0x00bb050c);
+	/* Bandwidth THR for of PRE0 */
+	writel(0x00000200, 0x00bb0690);
+	/* Bandwidth THR for of PRE1 */
+	writel(0x00000200, 0x00bb0710);
+	/* Bandwidth THR for of PRE2 */
+	writel(0x00000200, 0x00bb0790);
+	/* Bandwidth THR for of PRE3 */
+	writel(0x00000200, 0x00bb0810);
+	/* Saturation THR for of PRE0 */
+	writel(0x00000010, 0x00bb0694);
+	/* Saturation THR for of PRE1 */
+	writel(0x00000010, 0x00bb0714);
+	/* Saturation THR for of PRE2 */
+	writel(0x00000010, 0x00bb0794);
+	/* Saturation THR for of PRE */
+	writel(0x00000010, 0x00bb0814);
+
+	disable_ipu_clock();
+}
+
 int arch_cpu_init(void)
 {
 	struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
@@ -442,6 +471,9 @@ int arch_cpu_init(void)
 
 	init_src();
 
+	if (is_mx6dqp())
+		noc_setup();
+
 	return 0;
 }
 
Signature · 1 line
2.17.1
#8 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

Hi Fabio,

Quoted 39 lines

Subject: [PATCH 4/4] mx6: Allow configuring the NoC registers on i.MX6QP

The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.

Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.

---
 arch/arm/mach-imx/mx6/soc.c | 32
++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/mach-imx/mx6/soc.c +17 -0
index e80f1d484b..8de42408c7 100644
@@ -365,6 +365,35 @@ static void init_bandgap(void)
 	}
 }
 
+static void noc_setup(void)
+{
+	enable_ipu_clock();
+
+	writel(0x80000201, 0xbb0608);
+	/* Bypass IPU1 QoS generator */
+	writel(0x00000002, 0x00bb048c);
+	/* Bypass IPU2 QoS generator */
+	writel(0x00000002, 0x00bb050c);
+	/* Bandwidth THR for of PRE0 */
+	writel(0x00000200, 0x00bb0690);
+	/* Bandwidth THR for of PRE1 */
+	writel(0x00000200, 0x00bb0710);
+	/* Bandwidth THR for of PRE2 */
+	writel(0x00000200, 0x00bb0790);
+	/* Bandwidth THR for of PRE3 */
+	writel(0x00000200, 0x00bb0810);

arch/arm/mach-imx/mx6/soc.c static void init_bandgap(void) · line 394

Quoted 10 lines
arch/arm/mach-imx/mx6/soc.c +10 -0
+	/* Saturation THR for of PRE0 */
+	writel(0x00000010, 0x00bb0694);
+	/* Saturation THR for of PRE1 */
+	writel(0x00000010, 0x00bb0714);
+	/* Saturation THR for of PRE2 */
+	writel(0x00000010, 0x00bb0794);
+	/* Saturation THR for of PRE */
+	writel(0x00000010, 0x00bb0814);
+
+	disable_ipu_clock();

Why disable ipu clock?

Regards,
Peng.

Quoted 17 lines
arch/arm/mach-imx/mx6/soc.c +5 -1
+}
+
 int arch_cpu_init(void)
 {
 	struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
@@ -442,6 +471,9 @@ int arch_cpu_init(void)
 
 	init_src();
 
+	if (is_mx6dqp())
+		noc_setup();
+
 	return 0;
 }
 
--

2.17.1

author reviewer
#9 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

Hi Peng,

Quoted 1 line · Peng Fan

Why disable ipu clock?

Once the NoC registers are configured we no longer need to keep the IPU clocks turned on.

Thanks,

Fabio Estevam

#10 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

In reply to Fabio Estevam
Quoted 55 lines

Subject: [PATCH 4/4] mx6: Allow configuring the NoC registers on i.MX6QP

The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.

Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.

---
 arch/arm/mach-imx/mx6/soc.c | 32
++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/mach-imx/mx6/soc.c +29 -0
index e80f1d484b..8de42408c7 100644
@@ -365,6 +365,35 @@ static void init_bandgap(void)
 	}
 }
 
+static void noc_setup(void)
+{
+	enable_ipu_clock();
+
+	writel(0x80000201, 0xbb0608);
+	/* Bypass IPU1 QoS generator */
+	writel(0x00000002, 0x00bb048c);
+	/* Bypass IPU2 QoS generator */
+	writel(0x00000002, 0x00bb050c);
+	/* Bandwidth THR for of PRE0 */
+	writel(0x00000200, 0x00bb0690);
+	/* Bandwidth THR for of PRE1 */
+	writel(0x00000200, 0x00bb0710);
+	/* Bandwidth THR for of PRE2 */
+	writel(0x00000200, 0x00bb0790);
+	/* Bandwidth THR for of PRE3 */
+	writel(0x00000200, 0x00bb0810);
+	/* Saturation THR for of PRE0 */
+	writel(0x00000010, 0x00bb0694);
+	/* Saturation THR for of PRE1 */
+	writel(0x00000010, 0x00bb0714);
+	/* Saturation THR for of PRE2 */
+	writel(0x00000010, 0x00bb0794);
+	/* Saturation THR for of PRE */
+	writel(0x00000010, 0x00bb0814);
+
+	disable_ipu_clock();
+}
+
 int arch_cpu_init(void)
 {
 	struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;

arch/arm/mach-imx/mx6/soc.c int arch_cpu_init(void) · line 478

Quoted 8 lines
arch/arm/mach-imx/mx6/soc.c +3 -0
@@ -442,6 +471,9 @@ int arch_cpu_init(void)
 
 	init_src();
 
+	if (is_mx6dqp())
+		noc_setup();
+
 	return 0;
 }
Quoted 3 lines
arch/arm/mach-imx/mx6/soc.c +0 -1
--

2.17.1

author reviewer
#11 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

In reply to Fabio Estevam

Hi Stefano,

Quoted 8 lines · Fabio Estevam

The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.

Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.

It seems that only the first patch of this series got applied.

Could you please consider applying patches 2-4 too?

Thanks

#12 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

Quoted 7 lines · Fabio Estevam

Hi Stefano,

Quoted 4 lines · Fabio Estevam

The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.

Quoted 8 lines
Quoted 4 lines

Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.

It seems that only the first patch of this series got applied.

Could you please consider applying patches 2-4 too?

Something went wrong, patches were already set to "Accepted" in patchwork. I have picked up the rest of series, thanks for remind.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#13 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

Hi Fabio,

Quoted 11 lines · Stefano Babic
Quoted 10 lines · Fabio Estevam

Hi Stefano,

Quoted 7 lines · Fabio Estevam

The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.

Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

It seems that only the first patch of this series got applied.

Could you please consider applying patches 2-4 too?

Something went wrong, patches were already set to "Accepted" in patchwork. I have picked up the rest of series, thanks for remind.

I found a good reason why they were out. Patch 4 breaks the build for mx6sxsabresd because enable_[disable]ipu is called (of course, it should not be).

Could you take a look and repost ? Thanks !

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author reviewer
#14 lore raw

PATCH 4/4 mx6: Allow configuring the NoC registers on i.MX6QP

Hi Stefano,

Quoted 5 lines · Stefano Babic

I found a good reason why they were out. Patch 4 breaks the build for mx6sxsabresd because enable_[disable]ipu is called (of course, it should not be).

Could you take a look and repost ? Thanks !

Thanks for the feedback.

I have fixed it and submitted a v2.

Thanks