Skip to contentSkip to conversation

net: dsa: qca8k: replace legacy gpio include

PATCH Applied Christian Lamparter 4 participants 4 messages Jul 12, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: qca8k: replace legacy gpio include

This patch replaces the legacy bulk gpio.h include with the proper gpio/consumer.h variant. This was caught by the kbuild test robot that was running into an error because of this.

For more information why linux/gpio.h is bad can be found in:
commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy")

Fixes a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature")
---
 drivers/net/dsa/qca8k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/qca8k.c +1 -1
index 27709f866c23..232e8cc96f6d 100644
@@ -14,7 +14,7 @@
 #include <linux/of_platform.h>
 #include <linux/if_bridge.h>
 #include <linux/mdio.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/etherdevice.h>
 
 #include "qca8k.h"
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Christian Lamparter

This patch replaces the legacy bulk gpio.h include with the proper gpio/consumer.h variant. This was caught by the kbuild test robot that was running into an error because of this.

Quoted 7 lines

For more information why linux/gpio.h is bad can be found in:
commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy")

Fixes a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature")
Reviewed-by on v1 1/1
#2 lore raw
In reply to Christian Lamparter
Quoted 5 lines · Christian Lamparter

This patch replaces the legacy bulk gpio.h include with the proper gpio/consumer.h variant. This was caught by the kbuild test robot that was running into an error because of this.

Quoted 7 lines

For more information why linux/gpio.h is bad can be found in:
commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy")

Fixes a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature")
Signature · 1 line
Florian
maintainer Applied
#3 lore raw
In reply to Christian Lamparter

From: Christian Lamparter <[email protected]>
Date: Fri, 12 Jul 2019 17:33:36 +0200

Quoted 5 lines

This patch replaces the legacy bulk gpio.h include with the proper gpio/consumer.h variant. This was caught by the kbuild test robot that was running into an error because of this.

Quoted 7 lines

For more information why linux/gpio.h is bad can be found in:
commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy")

Fixes a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature")

Applied.