Skip to contentSkip to conversation

cmd: mdio: prevent data abort when no mdio bus is found

PATCH In review Simon Goldschmidt 3 participants 4 messages Jul 12, 2019 – Jul 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: mdio: prevent data abort when no mdio bus is found

Calling 'mdio read ...' currently leads to a data abort when no mdio bus is found.

To fix this, check if 'bus' is a valid pointer before accessing it.

---

 cmd/mdio.c | 5 +++++
 1 file changed, 5 insertions(+)
cmd/mdio.c +5 -0
index 5e219f699d..e1f771d3ed 100644
@@ -263,6 +263,11 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		break;
 	}
 
+	if (!bus) {
+		puts("No MDIO bus found\n");
+		return CMD_RET_FAILURE;
+	}
+
 	if (op[0] == 'l') {
 		mdio_list_devices();
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 cmd: mdio: prevent data abort when no mdio bus is found

Quoted 8 lines · Simon Goldschmidt

Calling 'mdio read ...' currently leads to a data abort when no mdio bus is found.

To fix this, check if 'bus' is a valid pointer before accessing it.

---

Quoted 23 lines
 cmd/mdio.c | 5 +++++
 1 file changed, 5 insertions(+)
cmd/mdio.c +5 -1
index 5e219f699d..e1f771d3ed 100644
@@ -263,6 +263,11 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                break;
        }
 
+       if (!bus) {
+               puts("No MDIO bus found\n");
+               return CMD_RET_FAILURE;
+       }
+
        if (op[0] == 'l') {
                mdio_list_devices();
 
--

2.20.1