nft: exit in case we can't fetch current genid
A message that is not in the archive (sent off-list or not yet received): [email protected]
Florian Westphal
maintainerPATCH 1/1 nft: exit in case we can't fetch current genid
When running iptables -nL as non-root user, iptables would loop indefinitely.
With this change, it will fail with
iptables v1.8.3 (nf_tables): Could not fetch rule set generation id: Permission denied (you must be root)
Reported-by Amish <[email protected]>
Signed-off-by Florian Westphal <[email protected]>
--- iptables/nft.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
iptables/nft.c +8 -2
@@ -82,13 +82,19 @@ out:return MNL_CB_ERROR ; } -static int mnl_genid_get (struct nft_handle *h,uint32_t *genid) +static void mnl_genid_get (struct nft_handle *h,uint32_t *genid) {char buf[MNL_SOCKET_BUFFER_SIZE ];struct nlmsghdr *nlh; +int ret; nlh =nftnl_nlmsg_build_hdr (buf,NFT_MSG_GETGEN ,0 ,0 , h->seq); -return mnl_talk (h, nlh, genid_cb, genid); + ret =mnl_talk (h, nlh, genid_cb, genid); +if (ret ==0 ) +return ; + +xtables_error (RESOURCE_PROBLEM , +"Could not fetch rule set generation id: %s\n" ,nft_strerror (errno)); } int mnl_talk(struct nft_handle *h, struct nlmsghdr *nlh,
Signature · 1 line
2.21.0
Quoted 7 lines · Florian Westphal
When running iptables -nL as non-root user, iptables would loop indefinitely.
With this change, it will fail with
iptables v1.8.3 (nf_tables): Could not fetch rule set generation id: Permission denied (you must be root)Reported-by Amish <[email protected]>Signed-off-by Florian Westphal <[email protected]>