Skip to contentSkip to conversation

gve: Remove the exporting of gve_probe

PATCH Applied Denis Efremov 2 participants 2 messages Jul 14, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gve: Remove the exporting of gve_probe

The function gve_probe is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

---
 drivers/net/ethernet/google/gve/gve_main.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/google/gve/gve_main.c +0 -1
index 24f16e3368cd..e8ee8cac2bbf 100644
@@ -1192,7 +1192,6 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	pci_disable_device(pdev);
 	return -ENXIO;
 }
-EXPORT_SYMBOL(gve_probe);
 
 static void gve_remove(struct pci_dev *pdev)
 {
Signature · 1 line
2.21.0
maintainer Applied
#1 lore raw

From: Denis Efremov <[email protected]>
Date: Sun, 14 Jul 2019 15:02:25 +0300

Quoted 6 lines

The function gve_probe is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Applied, thanks.