Skip to contentSkip to conversation

package/cpio: add host version

PATCH New Yann E. MORIN 3 participants 4 messages Jul 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/cpio: add host version

The latest cpio has a --reproducible option, which may come handy when we try to, well, be reproducible...

---
 package/cpio/cpio.mk | 3 +++
 1 file changed, 3 insertions(+)
package/cpio/cpio.mk +3 -0
index 9a09279572..d2814b87a5 100644
@@ -16,4 +16,7 @@ ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 CPIO_DEPENDENCIES += argp-standalone
 endif
 
+HOST_CPIO_CONF_OPTS = --bindir=$(HOST_DIR)/bin
+
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/cpio: add host version

Quoted 16 lines · Yann E. MORIN

The latest cpio has a --reproducible option, which may come handy when we try to, well, be reproducible...

---
 package/cpio/cpio.mk | 3 +++
 1 file changed, 3 insertions(+)
package/cpio/cpio.mk +0 -0
index 9a09279572..d2814b87a5 100644

package/cpio/cpio.mk ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y) · line 19

Quoted 4 lines
package/cpio/cpio.mk +1 -0
@@ -16,4 +16,7 @@ ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 CPIO_DEPENDENCIES += argp-standalone
 endif
 
+HOST_CPIO_CONF_OPTS = --bindir=$(HOST_DIR)/bin

Why is this needed? For target it is needed because --prefix is set to /usr so
it would end up in /usr/bin and we want it in /bin. But for hsot, --prefix is $(HOST_DIR).

Regards,
Arnout

Quoted 4 lines
package/cpio/cpio.mk +2 -0
+
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
#2 lore raw

PATCH 1/1 package/cpio: add host version

Arnout, All,

On 2019-07-14 14:19 +0200, Arnout Vandecappelle spake thusly:

Quoted 20 lines · Yann E. MORIN
Quoted 19 lines

The latest cpio has a --reproducible option, which may come handy when we try to, well, be reproducible...

---
 package/cpio/cpio.mk | 3 +++
 1 file changed, 3 insertions(+)
package/cpio/cpio.mk +0 -0
index 9a09279572..d2814b87a5 100644
@@ -16,4 +16,7 @@ ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 CPIO_DEPENDENCIES += argp-standalone
 endif
 
Quoted 5 lines

package/cpio/cpio.mk ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y) · line 19

Quoted 1 line
package/cpio/cpio.mk +1 -0
+HOST_CPIO_CONF_OPTS = --bindir=$(HOST_DIR)/bin

Why is this needed? For target it is needed because --prefix is set to /usr so
it would end up in /usr/bin and we want it in /bin. But for hsot, --prefix is $(HOST_DIR).

You know what? That is exactly what I think, too. ;-)

I just did a quick hack locally to test the build time of cpio, and did not try to think further, so I stupidly copied the target variant as-is without thinking too much.

Then I saw it worked, got the required timings from a batch of 5 runs, finished my reply to Atharva's fs/cpio patch, and decided to send this patch too, without realising that it needed a bit more love.

Atharva, when you respin your fs/cpio patch, can you grab this one in your tree and fix it as Arnout pointed out?

Regards,
Yann E. MORIN.

Quoted 7 lines

Regards,
Arnout

Quoted 4 lines
package/cpio/cpio.mk +2 -0
+
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/cpio: add host version

Quoted 38 lines · IST Yann E. MORIN

Arnout, All,

On 2019-07-14 14:19 +0200, Arnout Vandecappelle spake thusly:

Quoted 22 lines · Yann E. MORIN
Quoted 21 lines

The latest cpio has a --reproducible option, which may come handy when we try to, well, be reproducible...

---

 package/cpio/cpio.mk | 3 +++
 1 file changed, 3 insertions(+)
package/cpio/cpio.mk +0 -0
index 9a09279572..d2814b87a5 100644
@@ -16,4 +16,7 @@ ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 
 CPIO_DEPENDENCIES += argp-standalone
 endif
 
Quoted 6 lines

package/cpio/cpio.mk ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y) · line 19

Quoted 1 line
package/cpio/cpio.mk +1 -0
+HOST_CPIO_CONF_OPTS = --bindir=$(HOST_DIR)/bin

Why is this needed? For target it is needed because --prefix is set to /usr so>
it would end up in /usr/bin and we want it in /bin. But for hsot, --prefix is $(HOST_DIR).

You know what? That is exactly what I think, too. ;-)

I just did a quick hack locally to test the build time of cpio, and did not try to think further, so I stupidly copied the target variant as-is without thinking too much.

Quoted 6 lines

Then I saw it worked, got the required timings from a batch of 5 runs, finished my reply to Atharva's fs/cpio patch, and decided to send this patch too, without realising that it needed a bit more love.

Atharva, when you respin your fs/cpio patch, can you grab this one in your tree and fix it as Arnout pointed out?

I will :)

Quoted 11 lines

Regards,
Yann E. MORIN.

Quoted 8 lines

Regards,
Arnout

Quoted 5 lines
package/cpio/cpio.mk +2 -0
+
 
 $(eval $(autotools-package))
 
+$(eval $(host-autotools-package))

Regards,
Atharva Lele