Skip to contentSkip to conversation

configs: Make USE_TINY_PRINTF depend on SPL||TPL and be default

PATCH New Tom Rini 1 participant 2 messages Jun 8, 2019 – Jul 14, 2019

Subsystems (4)
lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 configs: Make USE_TINY_PRINTF depend on SPL||TPL and be default

The USE_TINY_PRINTF symbol only changes things within SPL and TPL builds, so make it depend on that support. Next, make it default as within these cases we should rarely have need of more advanced print formats outside of the debug context.

To do this, in a few cases we need to correct our Kconfig dependencies as we had cases of non-SPL targets select'ing this symbol. Finally, in the case of a few boards we really do need the full printf functionality.

---
 arch/arm/mach-omap2/Kconfig                     | 2 +-
 arch/arm/mach-rmobile/Kconfig.32                | 1 -
 configs/ls1043ardb_nand_SECURE_BOOT_defconfig   | 1 +
 configs/ls1043ardb_nand_defconfig               | 1 +
 configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig | 1 +
 configs/ls1043ardb_sdcard_defconfig             | 1 +
 configs/sandbox_spl_defconfig                   | 1 +
 lib/Kconfig                                     | 2 ++
 8 files changed, 8 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/Kconfig +1 -1
index d29f1ca0b58b..2cca417e103d 100644
@@ -11,7 +11,7 @@ config OMAP34XX
 	select ARM_ERRATA_454179
 	select ARM_ERRATA_621766
 	select ARM_ERRATA_725233
-	select USE_TINY_PRINTF
+	select USE_TINY_PRINTF if SPL
 	imply NAND_OMAP_GPMC
 	imply SPL_FS_EXT4
 	imply SPL_FS_FAT
arch/arm/mach-rmobile/Kconfig.32 +0 -1
index 67f669a6fc62..1441c8069207 100644
@@ -57,7 +57,6 @@ config TARGET_BLANCHE
 	bool "Blanche board"
 	select DM
 	select DM_SERIAL
-	select USE_TINY_PRINTF
 	imply CMD_DM
 
 config TARGET_GOSE
configs/ls1043ardb_nand_SECURE_BOOT_defconfig +1 -0
index 0a8a3659a070..60c2dbc3ca06 100644
@@ -67,6 +67,7 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+# CONFIG_USE_TINY_PRINTF is not set
 CONFIG_RSA=y
 CONFIG_SPL_RSA=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
configs/ls1043ardb_nand_defconfig +1 -0
index 6daa82ff40bd..2b0decb87f02 100644
@@ -67,4 +67,5 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+# CONFIG_USE_TINY_PRINTF is not set
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig +1 -0
index 4d9138f4de6b..15a0e42558d3 100644
@@ -65,6 +65,7 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+# CONFIG_USE_TINY_PRINTF is not set
 CONFIG_RSA=y
 CONFIG_SPL_RSA=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
configs/ls1043ardb_sdcard_defconfig +1 -0
index 9e71d0306387..81a045f470fd 100644
@@ -65,4 +65,5 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+# CONFIG_USE_TINY_PRINTF is not set
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
configs/sandbox_spl_defconfig +1 -0
index bebd78d55be5..c09852b222da 100644
@@ -191,6 +191,7 @@ CONFIG_OSD=y
 CONFIG_SANDBOX_OSD=y
 CONFIG_FS_CBFS=y
 CONFIG_FS_CRAMFS=y
+# CONFIG_USE_TINY_PRINTF is not set
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_TPM=y
 CONFIG_LZ4=y
lib/Kconfig +2 -0
index 416e63c1c736..50dbc34fe4b8 100644
@@ -97,6 +97,8 @@ config SYS_HZ
 
 config USE_TINY_PRINTF
 	bool "Enable tiny printf() version"
+	depends on SPL || TPL
+	default y
 	help
 	  This option enables a tiny, stripped down printf version.
 	  This should only be used in space limited environments,
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/1 configs: Make USE_TINY_PRINTF depend on SPL||TPL and be default

Quoted 11 lines · Tom Rini

The USE_TINY_PRINTF symbol only changes things within SPL and TPL builds, so make it depend on that support. Next, make it default as within these cases we should rarely have need of more advanced print formats outside of the debug context.

To do this, in a few cases we need to correct our Kconfig dependencies as we had cases of non-SPL targets select'ing this symbol. Finally, in the case of a few boards we really do need the full printf functionality.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190714/07b02f6e/attachment.sig>