Skip to contentSkip to conversation

package/x11r7/xlib_libXfont: work around gcc bug 85180

PATCH New Giulio Benetti 2 participants 3 messages Jul 13, 2019 – Jul 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/x11r7/xlib_libXfont: work around gcc bug 85180

With Microblaze Gcc version < 8.x the build hangs due to gcc bug 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug shows up when building xlib_libXfont with optimization but not when building with -O0. To work around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.

Fixes:
http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/

---
 package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/x11r7/xlib_libXfont/xlib_libXfont.mk +8 -0
index a1acfba83b..ba41970289 100644
@@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
 XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
 endif
 
+XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+XLIB_LIBXFONT_CFLAGS += -O0
+endif
+
+XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/x11r7/xlib_libXfont: work around gcc bug 85180

Hello,

Quoted 19 lines · On Sat, 13 Jul 2019 13:53:09 +0200 Giulio Benetti…

With Microblaze Gcc version < 8.x the build hangs due to gcc bug 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug shows up when building xlib_libXfont with optimization but not when building with -O0. To work around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.

Fixes:
http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/

---
 package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/x11r7/xlib_libXfont/xlib_libXfont.mk +0 -0
index a1acfba83b..ba41970289 100644

package/x11r7/xlib_libXfont/xlib_libXfont.mk ifeq ($(BR2_microblaze),y) · line 39

Quoted 10 lines
package/x11r7/xlib_libXfont/xlib_libXfont.mk +7 -0
@@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
 XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
 endif
 
+XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+XLIB_LIBXFONT_CFLAGS += -O0
+endif
+
+XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"

We normally use the <pkg>_CONF_ENV variable to override CFLAGS, so I fixed that up and applied. Thanks!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/x11r7/xlib_libXfont: work around gcc bug 85180

Hello Thomas,

Il 14/07/2019 15:07, Thomas Petazzoni ha scritto:

Quoted 27 lines

Hello,

Quoted 22 lines · On Sat, 13 Jul 2019 13:53:09 +0200 Giulio Benetti…

With Microblaze Gcc version < 8.x the build hangs due to gcc bug 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug shows up when building xlib_libXfont with optimization but not when building with -O0. To work around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.

Fixes:
http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/

---
  package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
  1 file changed, 8 insertions(+)
package/x11r7/xlib_libXfont/xlib_libXfont.mk +0 -0
index a1acfba83b..ba41970289 100644
@@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
  XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
  endif
 
Quoted 10 lines

package/x11r7/xlib_libXfont/xlib_libXfont.mk ifeq ($(BR2_microblaze),y) · line 39

Quoted 7 lines
package/x11r7/xlib_libXfont/xlib_libXfont.mk +7 -0
+XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+XLIB_LIBXFONT_CFLAGS += -O0
+endif
+
+XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"

We normally use the <pkg>_CONF_ENV variable to override CFLAGS, so I fixed that up and applied. Thanks!

You've changed and applied xlib_libXfont2, so I've sent a v2 patch for xlib_libXfont using <pkg>_CONF_ENV.

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642