Skip to contentSkip to conversation

examples/power: fix busyness number limed to 50%

PATCH Applied David Hunt 3 participants 3 messages Jul 15, 2019 – Jul 17, 2019

lore
Share & tools
lore

David Hunt

author
#0 lore raw

PATCH 1/1 examples/power: fix busyness number limed to 50%

Current implementation only outputs 3 numbers for busyness, 0, 50 and 100. Fix this so that the 50% is replaced by a curve, more meaningful. This can be replaced in each use case by a suitable calculation for that use case.

Fixes 609e79841fcf ("examples/l3fwd-power: add telemetry mode")
---
 examples/l3fwd-power/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
examples/l3fwd-power/main.c +3 -3
index 7a95605c4..cbe8f8e3f 100644
@@ -184,8 +184,8 @@ enum busy_rate {
  * reference CYCLES to be used to
  * measure core busyness based on poll count
  */
-#define MIN_CYCLES 1500000ULL
-#define MAX_CYCLES 2500000ULL
+#define MIN_CYCLES  1500000ULL
+#define MAX_CYCLES 22000000ULL
 
 /* (500ms) */
 #define TELEMETRY_INTERVALS_PER_SEC 2
@@ -1034,7 +1034,7 @@ main_telemetry_loop(__attribute__((unused)) void *dummy)
 				br = FULL;
 			} else if (diff_tsc > MIN_CYCLES &&
 					diff_tsc < MAX_CYCLES) {
-				br = PARTIAL;
+				br = (diff_tsc * 100) / MAX_CYCLES;
 			} else {
 				br = ZERO;
 			}
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · David Hunt

Current implementation only outputs 3 numbers for busyness, 0, 50 and 100. Fix this so that the 50% is replaced by a curve, more meaningful. This can be replaced in each use case by a suitable calculation for that use case.

Fixes 609e79841fcf ("examples/l3fwd-power: add telemetry mode")

---

Signature · 2 lines
Thanks,
Anatoly
#2 lore raw

16/07/2019 15:50, Burakov, Anatoly:

Quoted 11 lines · David Hunt
Quoted 8 lines

Current implementation only outputs 3 numbers for busyness, 0, 50 and 100. Fix this so that the 50% is replaced by a curve, more meaningful. This can be replaced in each use case by a suitable calculation for that use case.

Fixes 609e79841fcf ("examples/l3fwd-power: add telemetry mode")

Applied, thanks