X.509: Add messages for obsolete OIDs
Subsystems (3)
PATCH 1/1 X.509: Add messages for obsolete OIDs
We found that the db in Acer machine has self signed certificates (CN=DisablePW or CN«O) that they used obsolete OID 1.3.14.3.2.29 sha1WithRSASignature and 2.5.29.1 subjectKeyIdentifier. Kernel emits -65 error code when loading those certificates to platform keyring:
[ 1.484388] integrity: Loading X.509 certificate: UEFI:MokListRT [ 1.485557] integrity: Problem loading X.509 certificate -65 [ 1.486100] Error adding keys to platform keyring UEFI:MokListRT
Because the -65 error code is not enough for appeasing user when loading a outdated certificate. This patch add messages against 1.3.14.3.2.29 and 2.5.29.1 OIDs.
--- crypto/asymmetric_keys/x509_cert_parser.c | 7 +++++++ include/linux/oid_registry.h | 2 ++ 2 files changed, 9 insertions(+)
crypto/asymmetric_keys/x509_cert_parser.c +7 -0
@@ -192,6 +192,8 @@ int x509_note_pkey_algo(void *context, size_t hdrlen,pr_debug ("PubKey Algo: %u\n" , ctx->last_oid);switch (ctx->last_oid) { +case OID_sha1WithRSASignature: +pr_info ("1.3.14.3.2.29 sha1WithRSASignature is obsolete.\n" );case OID_md2WithRSAEncryption:case OID_md3WithRSAEncryption:default :
@@ -464,6 +466,11 @@ int x509_process_extension(void *context, size_t hdrlen,return 0 ; } +if (ctx->last_oid = OID_subjectKeyIdentifier_obsolete) { +pr_info ("2.5.29.1 subjectKeyIdentifier OID is obsolete.\n" ); +return -ENOPKG ; + } +return 0 ; }
include/linux/oid_registry.h +2 -0
@@ -62,6 +62,7 @@ enum OID { OID_certAuthInfoAccess,/* 1.3.6.1.5.5.7.1.1 */ OID_sha1,/* 1.3.14.3.2.26 */ + OID_sha1WithRSASignature,/* 1.3.14.3.2.29 */ OID_sha256,/* 2.16.840.1.101.3.4.2.1 */ OID_sha384,/* 2.16.840.1.101.3.4.2.2 */ OID_sha512, /* 2.16.840.1.101.3.4.2.3 */
@@ -83,6 +84,7 @@ enum OID { OID_generationalQualifier,/* 2.5.4.44 */ /* Certificate extension IDs */ + OID_subjectKeyIdentifier_obsolete,/* 2.5.29.1 */ OID_subjectKeyIdentifier,/* 2.5.29.14 */ OID_keyUsage,/* 2.5.29.15 */ OID_subjectAltName, /* 2.5.29.17 */
Signature · 1 line
2.16.4
Hi experts,
Quoted 14 lines · Chun-Yi
We found that the db in Acer machine has self signed certificates (CN=DisablePW or CN«O) that they used obsolete OID 1.3.14.3.2.29 sha1WithRSASignature and 2.5.29.1 subjectKeyIdentifier. Kernel emits -65 error code when loading those certificates to platform keyring:
[ 1.484388] integrity: Loading X.509 certificate: UEFI:MokListRT [ 1.485557] integrity: Problem loading X.509 certificate -65 [ 1.486100] Error adding keys to platform keyring UEFI:MokListRTBecause the -65 error code is not enough for appeasing user when loading a outdated certificate. This patch add messages against 1.3.14.3.2.29 and 2.5.29.1 OIDs.
Quoted 6 lines
Cc David Howells <[email protected]>Cc Herbert Xu <[email protected]>Cc "David S. Miller" <[email protected]>Reviewed-by Mimi Zohar <[email protected]>Signed-off-by "Lee, Chun-Yi" <[email protected]>
Have any update or comment for this patch?
Thanks
Joey Lee
Quoted 53 lines
--- crypto/asymmetric_keys/x509_cert_parser.c | 7 +++++++ include/linux/oid_registry.h | 2 ++ 2 files changed, 9 insertions(+)crypto/asymmetric_keys/x509_cert_parser.c +7
-0@@ -192,6 +192,8 @@ int x509_note_pkey_algo(void *context, size_t hdrlen,pr_debug ("PubKey Algo: %u\n" , ctx->last_oid);switch (ctx->last_oid) { +case OID_sha1WithRSASignature: +pr_info ("1.3.14.3.2.29 sha1WithRSASignature is obsolete.\n" );case OID_md2WithRSAEncryption:case OID_md3WithRSAEncryption:default :@@ -464,6 +466,11 @@ int x509_process_extension(void *context, size_t hdrlen,return 0 ; } +if (ctx->last_oid = OID_subjectKeyIdentifier_obsolete) { +pr_info ("2.5.29.1 subjectKeyIdentifier OID is obsolete.\n" ); +return -ENOPKG ; + } +return 0 ; }include/linux/oid_registry.h +2
-0@@ -62,6 +62,7 @@ enum OID { OID_certAuthInfoAccess,/* 1.3.6.1.5.5.7.1.1 */ OID_sha1,/* 1.3.14.3.2.26 */ + OID_sha1WithRSASignature,/* 1.3.14.3.2.29 */ OID_sha256,/* 2.16.840.1.101.3.4.2.1 */ OID_sha384,/* 2.16.840.1.101.3.4.2.2 */ OID_sha512, /* 2.16.840.1.101.3.4.2.3 */@@ -83,6 +84,7 @@ enum OID { OID_generationalQualifier,/* 2.5.4.44 */ /* Certificate extension IDs */ + OID_subjectKeyIdentifier_obsolete,/* 2.5.29.1 */ OID_subjectKeyIdentifier,/* 2.5.29.14 */ OID_keyUsage,/* 2.5.29.15 */ OID_subjectAltName, /* 2.5.29.17 */Signature · 1 line
2.16.4