net: ethernet: mscc: ocelot_board: Add of_node_put() before return
Subsystems (3)
PATCH 1/1 net: ethernet: mscc: ocelot_board: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/net/ethernet/mscc/ocelot_board.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/ethernet/mscc/ocelot_board.c +4 -1
@@ -291,8 +291,10 @@ static int mscc_ocelot_probe(struct platform_device *pdev)continue ; err =ocelot_probe_port (ocelot, port, regs, phy); -if (err) +if (err) { +of_node_put (portnp);return err; + } phy_mode =of_get_phy_mode (portnp);if (phy_mode <0 )
@@ -318,6 +320,7 @@ static int mscc_ocelot_probe(struct platform_device *pdev)dev_err (ocelot->dev,"invalid phy mode for port%d, (Q)SGMII only\n" , port); +of_node_put (portnp);return -EINVAL ; }
Signature · 1 line
2.19.1