net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto
Subsystems (4)
PATCH 1/1 net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto
Each iteration of for_each_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto. Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/mediatek/mtk_eth_soc.c +3 -1
@@ -2548,8 +2548,10 @@ static int mtk_probe(struct platform_device *pdev)continue ; err =mtk_add_mac (eth, mac_np); -if (err) +if (err) { +of_node_put (mac_np); goto err_deinit_hw; + } }if (MTK_HAS_CAPS (eth->soc->caps,MTK_SHARED_INT )) {
Signature · 1 line
2.19.1