Skip to contentSkip to conversation

mips: fix cacheinfo

PATCH Applied Vladimir Kondratiev 2 participants 2 messages Jul 16, 2019 – Jul 17, 2019 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mips: fix cacheinfo

Because CONFIG_OF defined for MIPS, cacheinfo attempts to fill information from DT, ignoring data filled by architecture routine. This leads to error reported

cacheinfo: Unable to detect cache hierarchy for CPU 0

Way to fix this provided in
commit fac51482577d ("drivers: base: cacheinfo: fix x86 with
CONFIG_OF enabled")

Utilize same mechanism to report that cacheinfo set by architecture specific function

---
 arch/mips/kernel/cacheinfo.c | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/kernel/cacheinfo.c +2 -0
index e0dd66881da6..f777e44653d5 100644
@@ -69,6 +69,8 @@ static int __populate_cache_leaves(unsigned int cpu)
 	if (c->tcache.waysize)
 		populate_cache(tcache, this_leaf, 3, CACHE_TYPE_UNIFIED);
 
+	this_cpu_ci->cpu_map_populated = true;
+
 	return 0;
 }
 
Signature · 1 line
2.20.1
Applied
#1 lore raw

Hello,

Quoted 6 lines · Vladimir Kondratiev

Because CONFIG_OF defined for MIPS, cacheinfo attempts to fill information from DT, ignoring data filled by architecture routine. This leads to error reported

cacheinfo: Unable to detect cache hierarchy for CPU 0

Quoted 8 lines

Way to fix this provided in
commit fac51482577d ("drivers: base: cacheinfo: fix x86 with CONFIG_OF enabled")

Utilize same mechanism to report that cacheinfo set by architecture specific function

Applied to mips-fixes.

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]