xfs: test statfs on project quota directory
PATCH v2 1/1 xfs: test statfs on project quota directory
There's a bug on xfs cause statfs get negative f_ffree value from a project quota directory. It's fixed by "de7243057 fs/xfs: fix f_ffree value for statfs when project quota is set". So add statfs testing on project quota block and inode count limit.
---
Hi,
This V2 patch changes this case from a generic case to a xfs only case, due to ext4 has different behavior.
V1 history:
https://marc.info/?l=linux-xfs&m=156048436902910&w=2
Thanks,
Zorro
tests/xfs/509 | 72 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/509.out | 3 ++ tests/xfs/group | 1 + 3 files changed, 76 insertions(+) create mode 100755 tests/xfs/509 create mode 100644 tests/xfs/509.out
tests/xfs/509 new file +72 -0
@@ -0,0 +1,72 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2019 Red Hat, Inc. All Rights Reserved. +# +# FS QA Test No. 509 +# +# Test statfs when project quota is set. +# Uncover de7243057 fs/xfs: fix f_ffree value for statfs when project quota is set +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + _scratch_unmount + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/quota + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs xfs +_supported_os Linux +_require_scratch +_require_xfs_quota + +_scratch_mkfs >/dev/null 2>&1 +_scratch_enable_pquota +_qmount_option "prjquota" +_qmount +_require_prjquota $SCRATCH_DEV + +# Create a directory to be project object, and create a file to take 64k space +mkdir $SCRATCH_MNT/t +$XFS_IO_PROG -f -c "pwrite 0 65536" -c sync $SCRATCH_MNT/t/file >>$seqres.full + +# Setup temporary replacements for /etc/projects and /etc/projid +cat >$tmp.projects <<EOF +42:$SCRATCH_MNT/t +EOF + +cat >$tmp.projid <<EOF +answer:42 +EOF + +quota_cmd="$XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid" +$quota_cmd -x -c 'project -s answer' $SCRATCH_MNT >/dev/null 2>&1 +$quota_cmd -x -c 'limit -p isoft=53 bsoft=100m answer' $SCRATCH_MNT + +# The itotal and size should be 53 and 102400(k), as above project quota limit. +# The isued and used should be 2 and 64(k), as this case takes. But ext4 always +# shows more 4k 'used' space than XFS, it prints 68k at here. So filter the +# 6[48] at the end. +df -k --output=file,itotal,iused,size,used $SCRATCH_MNT/t | \ + _filter_scratch | _filter_spaces + +# success, all done +status=0 +exit
tests/xfs/509.out new file +3 -0
@@ -0,0 +1,3 @@ +QA output created by 509 +File Inodes IUsed 1K-blocks Used +SCRATCH_MNT/t 53 2 102400 64
tests/xfs/group +1 -0
@@ -506,3 +506,4 @@ 506 auto quick health 507 clone 508 auto quick quota +509 auto quick quota
Signature · 1 line
2.17.2
Hi Zoro.
Quoted 5 lines · Zorro Lang
There's a bug on xfs cause statfs get negative
f_ffreevalue from a project quota directory. It's fixed by "de7243057fs/xfs: fixf_ffreevalue for statfs when project quota is set". So add statfs testing on project quota block and inode count limit.
Quoted 8 lines
Signed-off-by Zorro Lang <[email protected]>---
Hi,
This V2 patch changes this case from a generic case to a xfs only case, due to ext4 has different behavior.
.
.
.
Quoted 19 lines
tests/xfs/509 new file +19
-0+# real QA test starts here +_supported_fs xfs +_supported_os Linux +_require_scratch +_require_xfs_quota + +_scratch_mkfs >/dev/null 2>&1 +_scratch_enable_pquota +_qmount_option "prjquota" +_qmount +_require_prjquota $SCRATCH_DEV + +# Create a directory to be project object, and create a file to take 64k space +mkdir $SCRATCH_MNT/t +$XFS_IO_PROG -f -c "pwrite 0 65536" -c sync $SCRATCH_MNT/t/file >>$seqres.full + +# Setup temporary replacements for /etc/projects and /etc/projid +cat >$tmp.projects <<EOF +42:$SCRATCH_MNT/t
tests/xfs/509 line 61
Quoted 10 lines
tests/xfs/509 new file +9
-0+EOF + +cat >$tmp.projid <<EOF +answer:42 +EOF + +quota_cmd="$XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid" +$quota_cmd -x -c 'project -s answer' $SCRATCH_MNT >/dev/null 2>&1 +$quota_cmd -x -c 'limit -p isoft=53 bsoft=100m answer' $SCRATCH_MNT
I wonder if is there any specific reason why you're using project quota config files for this test? Maybe it would simplify the test if you replace the config files and the quota command by something like:
$quota_cmd -x -c 'answer -s -p $SCRATCH_MNT/t 42' $SCRATCH_MNT >/dev/null 2>&1 $quota_cmd -x -c 'limit -p isoft=53 bsoft=100m 42' $SCRATCH_MNT
Which would remove from the test all the configuration files setup
tests/xfs/509 line 66
Quoted 5 lines
tests/xfs/509 new file +5
-0+ +# The itotal and size should be 53 and 102400(k), as above project quota limit. +# The isued and used should be 2 and 64(k), as this case takes. But ext4 always +# shows more 4k 'used' space than XFS, it prints 68k at here. So filter the +# 6[48] at the end.
If this is a XFS only test, we don't need this comment right?
tests/xfs/509 line 69
Quoted 3 lines
tests/xfs/509 new file +3
-0+df -k --output=file,itotal,iused,size,used $SCRATCH_MNT/t | \ + _filter_scratch | _filter_spaces +
Cheers
Signature · 1 line
Carlos