Skip to contentSkip to conversation

drm/amdgpu: fix double fetch in amdgpu_ras_debugfs_ctrl_parse_data()

PATCH New JingYi Hou 1 participant 1 message Jul 16, 2019

Subsystems (2)
lore
Share & tools
lore

JingYi Hou

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix double fetch in amdgpu_ras_debugfs_ctrl_parse_data()

In amdgpu_ras_debugfs_ctrl_parse_data(), first fetch str from buf to get op value, if op == -1 which means no command matched, fetch data from buf again.

If change buf between two fetches may cause security problems or unexpected behaivor. amdgpu_ras_debugfs_ctrl_parse_data() was called by amdgpu_ras_debugfs_ctrl_write() and value of op was used later.

We should check whether data->op == -1 or not after second fetch. if data->op != -1 means buf changed and should return -EINVAL.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +3 -0
index 22bd21efe6b1..845e73e98cd7 100644
@@ -233,6 +233,9 @@ static int amdgpu_ras_debugfs_ctrl_parse_data(struct file *f,
 
 		if (copy_from_user(data, buf, sizeof(*data)))
 			return -EINVAL;
+
+		if(data->op != -1)
+			return -EINVAL;
 	}
 
 	return 0;

--
2.20.1