drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface
Subsystems (2)
PATCH 1/1 drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface
The register debugfs interface was using the wrong bitmask for vmid selection for GFX_CNTL.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1 -1
@@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, me = (*pos &GENMASK_ULL (33 ,24 )) >>24 ; pipe = (*pos &GENMASK_ULL (43 ,34 )) >>34 ; queue = (*pos &GENMASK_ULL (53 ,44 )) >>44 ; - vmid = (*pos &GENMASK_ULL (48 ,45 )) >>54 ; + vmid = (*pos &GENMASK_ULL (58 ,54 )) >>54 ; use_ring =1 ; }else {
Signature · 6 lines
2.21.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Christian König
Acked-byAm 16.07.19 um 13:24 schrieb StDenis, Tom:
Quoted 4 lines
The register debugfs interface was using the wrong bitmask for vmid selection for
GFX_CNTL.Signed-off-by Tom St Denis <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, · line 138
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1
-1@@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, me = (*pos &GENMASK_ULL (33 ,24 )) >>24 ; pipe = (*pos &GENMASK_ULL (43 ,34 )) >>34 ; queue = (*pos &GENMASK_ULL (53 ,44 )) >>44 ; - vmid = (*pos &GENMASK_ULL (48 ,45 )) >>54 ; + vmid = (*pos &GENMASK_ULL (58 ,54 )) >>54 ; use_ring =1 ; }else {
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): e6bc6d43-d4ac-467f-22b3-2be79619b93e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Thanks.
Alex can I grab an R-b please?
Cheers,
Tom
Quoted 12 lines · Christian König
Am 16.07.19 um 13:24 schrieb StDenis, Tom:
Quoted 4 lines
The register debugfs interface was using the wrong bitmask for vmid selection for
GFX_CNTL.Signed-off-by Tom St Denis <[email protected]>Acked-by Christian König <[email protected]>Quoted 4 lines
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0
-0drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_process_reg_op(bool · line 138
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1
-1@@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, me = (*pos & GENMASK_ULL(33, 24)) >> 24; pipe = (*pos & GENMASK_ULL(43, 34)) >> 34; queue = (*pos & GENMASK_ULL(53, 44)) >> 44; - vmid = (*pos & GENMASK_ULL(48, 45)) >> 54; + vmid = (*pos & GENMASK_ULL(58, 54)) >> 54; use_ring = 1; } else {
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 4d8fb065-f31b-d730-04d0-6c6e83b3a171-5C7GfCeVMHo@public.gmane.org
RB,
thanks,
Alex
________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of StDenis, Tom <[email protected]>
Sent: Wednesday, July 17, 2019 8:44 AM
To: Koenig, Christian; [email protected]
Subject: Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface
Thanks.
Alex can I grab an R-b please?
Cheers,
Tom
Quoted 12 lines · Christian König
Am 16.07.19 um 13:24 schrieb StDenis, Tom:
Quoted 4 lines
The register debugfs interface was using the wrong bitmask for vmid selection for
GFX_CNTL.Signed-off-by Tom St Denis <[email protected]>Acked-by Christian König <[email protected]>Quoted 4 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0
-0drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_process_reg_op(bool · line 138
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1
-1@@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, me = (*pos &GENMASK_ULL (33 ,24 )) >>24 ; pipe = (*pos &GENMASK_ULL (43 ,34 )) >>34 ; queue = (*pos &GENMASK_ULL (53 ,44 )) >>44 ; - vmid = (*pos &GENMASK_ULL (48 ,45 )) >>54 ; + vmid = (*pos &GENMASK_ULL (58 ,54 )) >>54 ; use_ring =1 ; }else {
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx