Skip to contentSkip to conversation

net/octeontx: use logtype_init for failed probe

PATCH Applied Stephen Hemminger 2 participants 4 messages Jul 16, 2019 – Jul 22, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/octeontx: use logtype_init for failed probe

All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to be deprecated in the future.

---
 drivers/net/octeontx/octeontx_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/octeontx/octeontx_ethdev.c +1 -1
index 1b853399dfe4..27eed47bb0cb 100644
@@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
 	    strlen(rte_vdev_device_args(dev)) == 0) {
 		eth_dev = rte_eth_dev_attach_secondary(dev_name);
 		if (!eth_dev) {
-			RTE_LOG(ERR, PMD, "Failed to probe %s\n", dev_name);
+			PMD_INIT_LOG(ERR, "Failed to probe %s", dev_name);
 			return -1;
 		}
 		/* TODO: request info from primary to set up Rx and Tx */
Signature · 1 line
2.20.1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Wednesday, July 17, 2019 12:18 AM
To: Jerin Jacob Kollanukkaran <[email protected]>
Cc: [email protected]
Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

Quoted 5 lines

All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to be deprecated in the future.

---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe
Quoted 21 lines
 drivers/net/octeontx/octeontx_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/octeontx/octeontx_ethdev.c +1 -1
index 1b853399dfe4..27eed47bb0cb 100644
@@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
 	    strlen(rte_vdev_device_args(dev)) == 0) {
 		eth_dev = rte_eth_dev_attach_secondary(dev_name);
 		if (!eth_dev) {
-			RTE_LOG(ERR, PMD, "Failed to probe %s\n",
 dev_name);
+			PMD_INIT_LOG(ERR, "Failed to probe %s",
 dev_name);
 			return -1;
drivers/net/octeontx/octeontx_ethdev.c +0 -1
 		}
 		/* TODO: request info from primary to set up Rx and Tx */
--

2.20.1

#2 lore raw
Quoted 10 lines · On Fri, 19 Jul 2019 03:37:26 +0000 Jerin Jacob Kollanukkaran…
Quoted 10 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Wednesday, July 17, 2019 12:18 AM
To: Jerin Jacob Kollanukkaran <[email protected]>
Cc: [email protected]
Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to be deprecated in the future.

Quoted 9 lines
Quoted 2 lines

---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe

OK but

That rule in check-git-log is still ridiculous because it rejects perfectly good commit subjects. The intention is good "stop automated bots" but the implementation rejects too many good patches.

#3 lore raw
Quoted 7 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Friday, July 19, 2019 10:29 PM
To: Jerin Jacob Kollanukkaran <[email protected]>
Cc: [email protected]
Subject: Re: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

Quoted 23 lines
Quoted 20 lines · On Fri, 19 Jul 2019 03:37:26 +0000 Jerin Jacob Kollanukkaran…
Quoted 8 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Wednesday, July 17, 2019 12:18 AM
To: Jerin Jacob Kollanukkaran <[email protected]>
Cc: [email protected]
Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

Quoted 5 lines

All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to be deprecated in the future.

---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe

Changed the git commit to:
net/octeontx: use driver logtype

Applied to dpdk-next-net-mrvl/master. Thanks

Quoted 6 lines

OK but

That rule in check-git-log is still ridiculous because it rejects perfectly good commit subjects. The intention is good "stop automated bots" but the implementation rejects too many good patches.