net/ark: implement dynamic log type
PATCH 1/1 net/ark: implement dynamic log type
The generic RTE_LOGTYPE_PMD is a historical relic and should
will be deprecated in near future. Every driver must register its own logtype.
Signed-off-by Stephen Hemminger <[email protected]>
--- drivers/net/ark/ark_ethdev.c | 9 +++++++++ drivers/net/ark/ark_logs.h | 25 ++++++++++++++----------- 2 files changed, 23 insertions(+), 11 deletions(-)
drivers/net/ark/ark_ethdev.c +9 -0
@@ -78,6 +78,8 @@ static int eth_ark_set_mtu(struct rte_eth_dev *dev, uint16_t size);#define ARK_TX_MAX_QUEUE (4096 * 4)#define ARK_TX_MIN_QUEUE (256) +int ark_logtype; +static const char *const valid_arguments[] = {ARK_PKTGEN_ARG ,ARK_PKTCHKR_ARG ,
@@ -1007,3 +1009,10 @@ RTE_PMD_REGISTER_PARAM_STRING(net_ark,ARK_PKTGEN_ARG "=<filename> " ARK_PKTCHKR_ARG "=<filename> " ARK_PKTDIR_ARG "=<bitmap>"); + +RTE_INIT (ark_init_log) +{ + ark_logtype =rte_log_register ("pmd.net.ark" ); +if (ark_logtype >=0 ) +rte_log_set_level (ark_logtype,RTE_LOG_NOTICE ); +}
drivers/net/ark/ark_logs.h +14 -11
@@ -26,29 +26,32 @@#define ARK_SU64X "\n\t%-20s %#20" PRIx64#define ARK_SPTR "\n\t%-20s %20p" - +extern int ark_logtype; #define PMD_DRV_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, fmt, ## args) + rte_log(RTE_LOG_ ##level, ark_logtype, fmt, ## args)/* Conditional trace definitions */ -#define ARK_TRACE_ON (level, fmt, ...) \ - RTE_LOG(level, PMD, fmt, ##__VA_ARGS__) +#define ARK_TRACE_ON(level, fmt, args...) \ + PMD_DRV_LOG(level, fmt, ## args)/* This pattern allows compiler check arguments even if disabled */ -#define ARK_TRACE_OFF (level, fmt, ...) \ - do {if (0) RTE_LOG(level, PMD, fmt, ##__VA_ARGS__); } \ - while (0) - +#define ARK_TRACE_OFF(level, fmt, args...) \ + do { \ + if (0) \ + PMD_DRV_LOG(level, fmt, ## args); \ + } while (0)/* tracing including the function name */ #define ARK_FUNC_ON(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args) + PMD_DRV_LOG(level, "%s(): " fmt, __func__, ## args)/* tracing including the function name */ #define ARK_FUNC_OFF(level, fmt, args...) \ - do { if (0) RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args); } \ - while (0) + do { \ + if (0) \ + PMD_DRV_LOG(level, "%s(): " fmt, __func__, ## args); \ + } while (0)/* Debug macro for tracing full behavior, function tracing and messages*/
Signature · 1 line
2.20.1
Quoted 4 lines · Stephen Hemminger
The generic
RTE_LOGTYPE_PMDis a historical relic and should
will be deprecated in near future. Every driver must register its own logtype.Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/master, thanks.