Skip to contentSkip to conversation

dt-bindings: iio: avia-hx711: Fix avdd-supply typo in example

PATCH In review Rob Herring 2 participants 3 messages Jul 16, 2019 – Jul 27, 2019

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: iio: avia-hx711: Fix avdd-supply typo in example

Now that examples are validated against the DT schema, a typo in avia-hx711 example generates a warning:

Documentation/devicetree/bindings/iio/adc/avia-hx711.example.dt.yaml: weight: 'avdd-supply' is a required property

Fix the typo.

Fixes 5150ec3fe125 ("avia-hx711.yaml: transform DT binding to YAML")
Cc Andreas Klinger <[email protected]>
Cc Jonathan Cameron <[email protected]>

---
Jonathan,

I have some other fixes I'm sending to Linus and can take these 2 if that's easier.

Rob

 Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml +1 -1
index 8a4100ceeaf2..d76ece97c76c 100644
@@ -61,6 +61,6 @@ examples:
         compatible = "avia,hx711";
         sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
         dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
-        avdd-suppy = <&avdd>;
+        avdd-supply = <&avdd>;
         clock-frequency = <100000>;
     };
Signature · 1 line
2.20.1
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: iio: ad7124: Fix dtc warnings in example

With the conversion to DT schema, the examples are now compiled with dtc. The ad7124 binding example has the following warning:

Documentation/devicetree/bindings/iio/adc/adi,ad7124.example.dts:19.11-21: \
Warning (reg_format): /example-0/adc@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)

There's a default #size-cells and #address-cells values of 1 for examples. For examples needing different values such as this one on a SPI bus, they need to provide a SPI bus parent node.

Fixes 26ae15e62d3c ("Convert AD7124 bindings documentation to YAML format.")
---
 .../bindings/iio/adc/adi,ad7124.yaml          | 71 ++++++++++---------
 1 file changed, 38 insertions(+), 33 deletions(-)
Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml +38 -33
index cf494a08b837..9692b7f719f5 100644
@@ -114,42 +114,47 @@ patternProperties:
 
 examples:
   - |
-    adc@0 {
-      compatible = "adi,ad7124-4";
-      reg = <0>;
-      spi-max-frequency = <5000000>;
-      interrupts = <25 2>;
-      interrupt-parent = <&gpio>;
-      refin1-supply = <&adc_vref>;
-      clocks = <&ad7124_mclk>;
-      clock-names = "mclk";
-
+    spi {
       #address-cells = <1>;
       #size-cells = <0>;
 
-      channel@0 {
+      adc@0 {
+        compatible = "adi,ad7124-4";
         reg = <0>;
-        diff-channels = <0 1>;
-        adi,reference-select = <0>;
-        adi,buffered-positive;
-      };
-
-      channel@1 {
-        reg = <1>;
-        bipolar;
-        diff-channels = <2 3>;
-        adi,reference-select = <0>;
-        adi,buffered-positive;
-        adi,buffered-negative;
-      };
-
-      channel@2 {
-        reg = <2>;
-        diff-channels = <4 5>;
-      };
-
-      channel@3 {
-        reg = <3>;
-        diff-channels = <6 7>;
+        spi-max-frequency = <5000000>;
+        interrupts = <25 2>;
+        interrupt-parent = <&gpio>;
+        refin1-supply = <&adc_vref>;
+        clocks = <&ad7124_mclk>;
+        clock-names = "mclk";
+
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        channel@0 {
+          reg = <0>;
+          diff-channels = <0 1>;
+          adi,reference-select = <0>;
+          adi,buffered-positive;
+        };
+
+        channel@1 {
+          reg = <1>;
+          bipolar;
+          diff-channels = <2 3>;
+          adi,reference-select = <0>;
+          adi,buffered-positive;
+          adi,buffered-negative;
+        };
+
+        channel@2 {
+          reg = <2>;
+          diff-channels = <4 5>;
+        };
+
+        channel@3 {
+          reg = <3>;
+          diff-channels = <6 7>;
+        };
       };
     };
Signature · 1 line
2.20.1
maintainer
#2 lore raw
In reply to Rob Herring
Quoted 12 lines · On Tue, 16 Jul 2019 14:33:23 -0600 Rob Herring <[email protected]> wrote:

Now that examples are validated against the DT schema, a typo in avia-hx711 example generates a warning:

Documentation/devicetree/bindings/iio/adc/avia-hx711.example.dt.yaml: weight: 'avdd-supply' is a required property

Fix the typo.

Fixes 5150ec3fe125 ("avia-hx711.yaml: transform DT binding to YAML")
Cc Andreas Klinger <[email protected]>
Cc Jonathan Cameron <[email protected]>
Quoted 7 lines

---
Jonathan,

I have some other fixes I'm sending to Linus and can take these 2 if that's easier.

Rob

Thanks for dealing with these, I missed this thread entirely in my email whilst travelling / playing catch up.

Jonathan

Quoted 16 lines
 Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml +1 -1
index 8a4100ceeaf2..d76ece97c76c 100644
@@ -61,6 +61,6 @@ examples:
         compatible = "avia,hx711";
         sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
         dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
-        avdd-suppy = <&avdd>;
+        avdd-supply = <&avdd>;
         clock-frequency = <100000>;
     };