Skip to contentSkip to conversation

migration: remove unused field bytes_xfer

PATCH In review Wei Yang 4 participants 9 messages Apr 2, 2019 – Aug 7, 2019

lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH 1/1 migration: remove unused field bytes_xfer

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

---
 migration/migration.c | 1 -
 migration/migration.h | 1 -
 2 files changed, 2 deletions(-)
migration/migration.c +0 -1
index dea7078bf4..c929cf8d0f 100644
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
      * parameters/capabilities that the user set, and
      * locks.
      */
-    s->bytes_xfer = 0;
     s->cleanup_bh = 0;
     s->to_dst_file = NULL;
     s->rp_state.from_dst_file = NULL;
migration/migration.h +0 -1
index 852eb3c4e9..b9efbe9168 100644
@@ -116,7 +116,6 @@ struct MigrationState
     DeviceState parent_obj;
 
     /*< public >*/
-    size_t bytes_xfer;
     QemuThread thread;
     QEMUBH *cleanup_bh;
     QEMUFile *to_dst_file;
Signature · 1 line
2.19.1
author
#1 lore raw
Quoted 5 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Hi, David

Are you willing to pick up this one?

Quoted 31 lines

---
migration/migration.c | 1 -
migration/migration.h | 1 -

2 files changed, 2 deletions(-)
migration/migration.c +0 -1
index dea7078bf4..c929cf8d0f 100644
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
     * parameters/capabilities that the user set, and
     * locks.
     */
-    s->bytes_xfer = 0;
    s->cleanup_bh = 0;
    s->to_dst_file = NULL;
    s->rp_state.from_dst_file = NULL;
migration/migration.h +0 -1
index 852eb3c4e9..b9efbe9168 100644
@@ -116,7 +116,6 @@ struct MigrationState
    DeviceState parent_obj;
 
    /*< public >*/
-    size_t bytes_xfer;
    QemuThread thread;
    QEMUBH *cleanup_bh;
    QEMUFile *to_dst_file;
Signature · 1 line
2.19.1
Signature · 2 lines
Wei Yang
Help you, Help me
#2 lore raw
Quoted 8 lines · Wei Yang
Quoted 5 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Hi, David

Hi

I am on duty this week, will get it.

Quoted 34 lines

Are you willing to pick up this one?

Quoted 31 lines

---
migration/migration.c | 1 -
migration/migration.h | 1 -

2 files changed, 2 deletions(-)
migration/migration.c +0 -1
index dea7078bf4..c929cf8d0f 100644
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
     * parameters/capabilities that the user set, and
     * locks.
     */
-    s->bytes_xfer = 0;
    s->cleanup_bh = 0;
    s->to_dst_file = NULL;
    s->rp_state.from_dst_file = NULL;
migration/migration.h +0 -1
index 852eb3c4e9..b9efbe9168 100644
@@ -116,7 +116,6 @@ struct MigrationState
    DeviceState parent_obj;
 
    /*< public >*/
-    size_t bytes_xfer;
    QemuThread thread;
    QEMUBH *cleanup_bh;
    QEMUFile *to_dst_file;
Signature · 1 line
2.19.1
author
#3 lore raw
Quoted 6 lines · Juan Quintela
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Hi, David

Hi

I am on duty this week, will get it.

Thanks :-)

Quoted 35 lines
Quoted 35 lines

Are you willing to pick up this one?

Quoted 31 lines

---
migration/migration.c | 1 -
migration/migration.h | 1 -

2 files changed, 2 deletions(-)
migration/migration.c +0 -1
index dea7078bf4..c929cf8d0f 100644
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
     * parameters/capabilities that the user set, and
     * locks.
     */
-    s->bytes_xfer = 0;
    s->cleanup_bh = 0;
    s->to_dst_file = NULL;
    s->rp_state.from_dst_file = NULL;
migration/migration.h +0 -1
index 852eb3c4e9..b9efbe9168 100644
@@ -116,7 +116,6 @@ struct MigrationState
    DeviceState parent_obj;
 
    /*< public >*/
-    size_t bytes_xfer;
    QemuThread thread;
    QEMUBH *cleanup_bh;
    QEMUFile *to_dst_file;
Signature · 1 line
2.19.1
Signature · 2 lines
Wei Yang
Help you, Help me
author
#4 lore raw
In reply to Juan Quintela
Quoted 6 lines · Juan Quintela
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Hi, David

Hi

I am on duty this week, will get it.

Hi, Juan,

May I ask when you are willing to pick it up?

Quoted 34 lines
Quoted 34 lines

Are you willing to pick up this one?

Quoted 31 lines

---
migration/migration.c | 1 -
migration/migration.h | 1 -

2 files changed, 2 deletions(-)
migration/migration.c +0 -1
index dea7078bf4..c929cf8d0f 100644
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
     * parameters/capabilities that the user set, and
     * locks.
     */
-    s->bytes_xfer = 0;
    s->cleanup_bh = 0;
    s->to_dst_file = NULL;
    s->rp_state.from_dst_file = NULL;
migration/migration.h +0 -1
index 852eb3c4e9..b9efbe9168 100644
@@ -116,7 +116,6 @@ struct MigrationState
    DeviceState parent_obj;
 
    /*< public >*/
-    size_t bytes_xfer;
    QemuThread thread;
    QEMUBH *cleanup_bh;
    QEMUFile *to_dst_file;
Signature · 1 line
2.19.1
Signature · 2 lines
Wei Yang
Help you, Help me
author
#5 lore raw
In reply to Juan Quintela
Quoted 6 lines · Juan Quintela
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Hi, David

Hi

I am on duty this week, will get it.

Hi, Juan

Sounds we lost this one and the one above this :-)

Signature · 2 lines
Wei Yang
Help you, Help me
#6 lore raw
Quoted 11 lines · * Wei Yang ([email protected]) wrote:
Quoted 10 lines · Juan Quintela
Quoted 8 lines · Wei Yang
Quoted 5 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Hi, David

Quoted 9 lines
Quoted 4 lines

Hi

I am on duty this week, will get it.

Hi, Juan

Sounds we lost this one and the one above this :-)

We're in freeze at the moment; we'll pick it up as soon
as it opens up again; I've got quite a list of your clean-up patches!

Dave

Quoted 3 lines
Signature · 2 lines
Wei Yang
Help you, Help me

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

#7 lore raw
Quoted 17 lines · Dr. David Alan Gilbert
Quoted 16 lines · * Wei Yang ([email protected]) wrote:
Quoted 14 lines · Juan Quintela
Quoted 8 lines · Wei Yang
Quoted 5 lines · Wei Yang

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Hi, David

Hi

I am on duty this week, will get it.

Quoted 8 lines
Quoted 4 lines

Hi, Juan

Sounds we lost this one and the one above this :-)

We're in freeze at the moment; we'll pick it up as soon
as it opens up again; I've got quite a list of your clean-up patches!

Thanks for your reply.

Have a good weekend. :-)

Quoted 7 lines

Dave

Quoted 3 lines
Signature · 2 lines
Wei Yang
Help you, Help me

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

Signature · 2 lines
Wei Yang
Help you, Help me
#8 lore raw
In reply to Wei Yang
Quoted 5 lines · * Wei Yang ([email protected]) wrote:

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Queued (finally!)

Quoted 33 lines
---
 migration/migration.c | 1 -
 migration/migration.h | 1 -
 2 files changed, 2 deletions(-)
migration/migration.c +0 -1
index dea7078bf4..c929cf8d0f 100644
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
      * parameters/capabilities that the user set, and
      * locks.
      */
-    s->bytes_xfer = 0;
     s->cleanup_bh = 0;
     s->to_dst_file = NULL;
     s->rp_state.from_dst_file = NULL;
migration/migration.h +0 -1
index 852eb3c4e9..b9efbe9168 100644
@@ -116,7 +116,6 @@ struct MigrationState
     DeviceState parent_obj;
 
     /*< public >*/
-    size_t bytes_xfer;
     QemuThread thread;
     QEMUBH *cleanup_bh;
     QEMUFile *to_dst_file;
Signature · 1 line
2.19.1

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK