package/python-idna: select PYTHON3_UNICODEDATA
PATCH 1/1 package/python-idna: select PYTHON3_UNICODEDATA
--- package/python-idna/Config.in | 1 + 1 file changed, 1 insertion(+)
package/python-idna/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_IDNA bool "python-idna" + select BR2_PACKAGE_PYTHON3_UNICODEDATA help A library to support the Internationalised Domain Names in Applications (IDNA) protocol as specified in RFC 5891. This
Signature · 1 line
2.22.0
PATCH 1/1 package/python-idna: select PYTHON3_UNICODEDATA
Hello Alex,
Quoted 1 line · On Tue, 16 Jul 2019 13:58:30 -0400 "Alex Xu (Hello71)" <[email protected]>…
Signed-off-by Alex Xu (Hello71) <[email protected]>
Thanks for your patch. However, the commit log is empty, and therefore it doesn't carry any explanation as to why this change is necessary. Could you give more details ?
package/python-idna/Config.in line 3
Quoted 8 lines
package/python-idna/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_IDNA bool "python-idna" + select BR2_PACKAGE_PYTHON3_UNICODEDATA
Nit: there is an indentation problem, we indent those lines with a tab, not with spaces.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/python-idna: select PYTHON3_UNICODEDATA
idna requires unicodedata:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "usr/lib/python3.7/site-packages/idna/__init__.py", line 2, in <module> File "usr/lib/python3.7/site-packages/idna/core.py", line 3, in <module>
ModuleNotFoundError: No module named 'unicodedata'
--- package/python-idna/Config.in | 1 + 1 file changed, 1 insertion(+)
package/python-idna/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_IDNA bool "python-idna" + select BR2_PACKAGE_PYTHON3_UNICODEDATA help A library to support the Internationalised Domain Names in Applications (IDNA) protocol as specified in RFC 5891. This
Signature · 1 line
2.22.0
PATCH v2 1/1 package/python-idna: select PYTHON3_UNICODEDATA
Hello Alex,
Thanks for the new iteration of the patch. There was still an issue, but see below.
package/python-idna/Config.in line 3
Quoted 8 lines · On Wed, 17 Jul 2019 15:12:15 -0400 "Alex Xu (Hello71)" <[email protected]>…
package/python-idna/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_IDNA bool "python-idna" + select BR2_PACKAGE_PYTHON3_UNICODEDATA
This only takes care of the case where python3 is used, by python-idna can also be used when python (2.x) is selected.
So I changed this to:
+ select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3
and applied.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/python-idna: select PYTHON3_UNICODEDATA
Quoted 26 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Hello Alex,
Thanks for the new iteration of the patch. There was still an issue, but see below.package/python-idna/Config.in line 3
Quoted 8 lines · On Wed, 17 Jul 2019 15:12:15 -0400 "Alex Xu (Hello71)" <[email protected]>…
package/python-idna/Config.in +0
-0@@ -1,5 +1,6 @@config
BR2_PACKAGE_PYTHON_IDNA
bool "python-idna"package/python-idna/Config.in +1
-0+ select BR2_PACKAGE_PYTHON3_UNICODEDATAThis only takes care of the case where python3 is used, by python-idna can also be used when python (2.x) is selected.
So I changed this to:
(quoted diff) +2
-0+ select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3
Quoted 1 line
and applied.
Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.
Signature · 1 line
Bye, Peter Korsgaard