Skip to contentSkip to conversation

travis: Build and test ASPEED board

PATCH New Joel Stanley 2 participants 17 messages Jul 4, 2019 – Jul 18, 2019

lore
Share & tools
lore
#0 lore raw

cover travis: Build and test ASPEED board

Tom suggested I add support for booting the ASPEED EVB configuration in Qemu. This series fixes up a few things with the defconfig so buildman passes, and makes u-boot testable:

https://travis-ci.com/shenki/u-boot/builds/117772801

I've sent some patches to Stephen for uboot-test-scripts tools that need to be merged before this Travis configuration can go in.

Joel Stanley (5):
configs: aspeed: Unset CONFIG_MMC
configs: aspeed: Add HUSH and random ethernet addr
traivs: Build aspeed boards
travis: Add ASPEED ast2500 to qemu tests
travis: Build aspeed board with qemu HEAD

 .travis.yml                   | 10 ++++++++++
 configs/evb-ast2500_defconfig |  3 +++
 2 files changed, 13 insertions(+)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/5 configs: aspeed: Unset CONFIG_MMC

The aspeed board does not have an upstream MMC driver.

As CONFIG_MMC defaults on, the board would fail to build due to the CONFIG_DM_MMC migration:

===================== WARNING ====================== This board does not use CONFIG_DM_MMC. Please update the board to use CONFIG_DM_MMC before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Change the defconfig to disable MMC until a driver is submitted.

---
 configs/evb-ast2500_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/evb-ast2500_defconfig +1 -0
index b73da72b1654..245c73ee9b5d 100644
@@ -21,6 +21,7 @@ CONFIG_REGMAP=y
 CONFIG_CLK=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_ASPEED=y
+# CONFIG_MMC is not set
 CONFIG_PHY_REALTEK=y
 CONFIG_DM_ETH=y
 CONFIG_FTGMAC100=y
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/5 configs: aspeed: Unset CONFIG_MMC

Quoted 12 lines · Joel Stanley

The aspeed board does not have an upstream MMC driver.

As CONFIG_MMC defaults on, the board would fail to build due to the CONFIG_DM_MMC migration:

===================== WARNING ====================== This board does not use CONFIG_DM_MMC. Please update the board to use CONFIG_DM_MMC before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Quoted 3 lines

Change the defconfig to disable MMC until a driver is submitted.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190718/d6b4b56a/attachment.sig>
#3 lore raw

PATCH 2/5 configs: aspeed: Add HUSH and random ethernet addr

In reply to Joel Stanley

Tests in test/py/tests/test_env.py like this fail without CONFIG_HUSH_PARSER:

=> => printenv test_env_0
## Error: "test_env_0" not defined
=> .=> setenv test_env_0
=> => echo $test_env_0
$test_env_0
=> F

We also want a mac address so the ethernet device works in qemu.

---
 configs/evb-ast2500_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/evb-ast2500_defconfig +2 -0
index 245c73ee9b5d..59d41cb5687b 100644
@@ -11,12 +11,14 @@ CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
 CONFIG_PRE_CONSOLE_BUFFER=y
 CONFIG_PRE_CON_BUF_ADDR=0x1e720000
 # CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_HUSH_PARSER=y
 # CONFIG_AUTO_COMPLETE is not set
 CONFIG_CMD_I2C=y
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
 CONFIG_CLK=y
 CONFIG_DM_I2C=y
Signature · 1 line
2.20.1
#4 lore raw

PATCH 2/5 configs: aspeed: Add HUSH and random ethernet addr

Quoted 9 lines · Joel Stanley

Tests in test/py/tests/test_env.py like this fail without CONFIG_HUSH_PARSER:

=> => printenv test_env_0
## Error: "test_env_0" not defined
=> .=> setenv test_env_0
=> => echo $test_env_0
$test_env_0
=> F

Quoted 3 lines

We also want a mac address so the ethernet device works in qemu.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190718/fec3b9ef/attachment.sig>
#5 lore raw

PATCH 3/5 traivs: Build aspeed boards

In reply to Joel Stanley

Currently we only have one, but this will expand to cover other boards as they are supported.

---
 .travis.yml | 3 +++
 1 file changed, 3 insertions(+)
.travis.yml +3 -0
index 6662ca126ab5..53dade5ae116 100644
@@ -169,6 +169,9 @@ matrix:
       env:
         - JOB="arm926ejs"
           BUILDMAN="arm926ejs -x freescale,siemens,at91,kirkwood,spear,omap"
+    - name: 'buildman aspeed'
+      env:
+        - BUILDMAN="aspeed"
     - name: "buildman at91 (non arm v7)"
       env:
         - BUILDMAN="at91 -x armv7"
Signature · 1 line
2.20.1
#6 lore raw

PATCH 3/5 traivs: Build aspeed boards

Quoted 13 lines · Joel Stanley

Currently we only have one, but this will expand to cover other boards as they are supported.

---
 .travis.yml | 3 +++
 1 file changed, 3 insertions(+)
.travis.yml +0 -0
index 6662ca126ab5..53dade5ae116 100644

.travis.yml matrix: · line 177

Quoted 9 lines
.travis.yml +3 -0
@@ -169,6 +169,9 @@ matrix:
       env:
         - JOB="arm926ejs"
           BUILDMAN="arm926ejs -x freescale,siemens,at91,kirkwood,spear,omap"
+    - name: 'buildman aspeed'
+      env:
+        - BUILDMAN="aspeed"
     - name: "buildman at91 (non arm v7)"
       env:
         - BUILDMAN="at91 -x armv7"

This isn't needed as the job that builds all matches to arm11 arm7 arm920t arm946es builds it.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190717/41b8a6a0/attachment.sig>
#7 lore raw

PATCH 3/5 traivs: Build aspeed boards

Quoted 20 lines · Tom Rini
Quoted 17 lines · Joel Stanley

Currently we only have one, but this will expand to cover other boards as they are supported.

---
 .travis.yml | 3 +++
 1 file changed, 3 insertions(+)
.travis.yml +1 -0
index 6662ca126ab5..53dade5ae116 100644
@@ -169,6 +169,9 @@ matrix:
       env:
         - JOB="arm926ejs"
           BUILDMAN="arm926ejs -x freescale,siemens,at91,kirkwood,spear,omap"
+    - name: 'buildman aspeed'
Quoted 8 lines

.travis.yml matrix: · line 177

Quoted 5 lines
.travis.yml +2 -0
+      env:
+        - BUILDMAN="aspeed"
     - name: "buildman at91 (non arm v7)"
       env:
         - BUILDMAN="at91 -x armv7"

This isn't needed as the job that builds all matches to arm11 arm7 arm920t arm946es builds it.

I thought this might be the case, but I did some testing and it didn't seem to build the ast2500 evb configuration. Neither does the arm catch all. Can you point out where I've gone wrong?

Is there a way to get buildman to print the boards it would build for?

Cheers,

Joel

#8 lore raw

PATCH 3/5 traivs: Build aspeed boards

Quoted 30 lines · Joel Stanley
Quoted 20 lines · Tom Rini
Quoted 17 lines · Joel Stanley

Currently we only have one, but this will expand to cover other boards as they are supported.

---
 .travis.yml | 3 +++
 1 file changed, 3 insertions(+)
.travis.yml +1 -0
index 6662ca126ab5..53dade5ae116 100644
@@ -169,6 +169,9 @@ matrix:
       env:
         - JOB="arm926ejs"
           BUILDMAN="arm926ejs -x freescale,siemens,at91,kirkwood,spear,omap"
+    - name: 'buildman aspeed'
Quoted 8 lines

.travis.yml matrix: · line 177

Quoted 5 lines
.travis.yml +2 -0
+      env:
+        - BUILDMAN="aspeed"
     - name: "buildman at91 (non arm v7)"
       env:
         - BUILDMAN="at91 -x armv7"

This isn't needed as the job that builds all matches to arm11 arm7 arm920t arm946es builds it.

Quoted 5 lines

I thought this might be the case, but I did some testing and it didn't seem to build the ast2500 evb configuration. Neither does the arm catch all. Can you point out where I've gone wrong?

Is there a way to get buildman to print the boards it would build for?

You can see it for example in:
https://travis-ci.org/trini/u-boot/jobs/560025248#L1114

But if you modified .travis.yml to pass --dry-run -v to buildman it would instead just list what it would build for.

FWIW, there's no need to repost the series, I'm going to push things shortly, once the GitLab run finishes.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190717/f854e229/attachment.sig>
#9 lore raw

PATCH 3/5 traivs: Build aspeed boards

Quoted 10 lines · Tom Rini
Quoted 8 lines · Joel Stanley
Quoted 2 lines · Tom Rini

This isn't needed as the job that builds all matches to arm11 arm7 arm920t arm946es builds it.

I thought this might be the case, but I did some testing and it didn't seem to build the ast2500 evb configuration. Neither does the arm catch all. Can you point out where I've gone wrong?

Quoted 7 lines
Quoted 1 line

Is there a way to get buildman to print the boards it would build for?

You can see it for example in:
https://travis-ci.org/trini/u-boot/jobs/560025248#L1114

But if you modified .travis.yml to pass --dry-run -v to buildman it would instead just list what it would build for.

Thanks, it makes sense to me with my local setup too now.

Quoted 2 lines

FWIW, there's no need to repost the series, I'm going to push things shortly, once the GitLab run finishes.

Great, thank you.

In the near future we're going to start pushing up more drivers, and then a cortex-a7 variant of the soc.

Cheers,

Joel

#10 lore raw

PATCH 4/5 travis: Add ASPEED ast2500 to qemu tests

In reply to Joel Stanley
---
 .travis.yml | 7 +++++++
 1 file changed, 7 insertions(+)
.travis.yml +7 -0
index 53dade5ae116..69ae1c8b4223 100644
@@ -387,6 +387,13 @@ matrix:
         - TEST_PY_BD="sandbox_flattree"
           BUILDMAN="^sandbox_flattree$"
           TOOLCHAIN="i386"
+    - name: "test/py evb-ast2500"
+      env:
+        - TEST_PY_BD="evb-ast2500"
+          TEST_PY_ID="--id qemu"
+          QEMU_TARGET="arm-softmmu"
+          QEMU_VERSION="v4.0.0"
+          BUILDMAN="^evb-ast2500$"
     - name: "test/py vexpress_ca15_tc2"
       env:
         - TEST_PY_BD="vexpress_ca15_tc2"
Signature · 1 line
2.20.1
#11 lore raw

PATCH 4/5 travis: Add ASPEED ast2500 to qemu tests

Quoted 1 line · Joel Stanley

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190718/5e9e40ba/attachment.sig>
#12 lore raw

PATCH 5/5 travis: Build aspeed board with qemu HEAD

In reply to Joel Stanley

In order to boot u-boot in the aspeed machine we need to run at least qemu 3059c2f5a813 (v4.0.0-1592-g3059c2f5a813), which is not in a released tag.

This should be changed to v4.1.0 when it is released.

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.travis.yml +1 -1
index 69ae1c8b4223..9addfba4dd93 100644
@@ -392,7 +392,7 @@ matrix:
         - TEST_PY_BD="evb-ast2500"
           TEST_PY_ID="--id qemu"
           QEMU_TARGET="arm-softmmu"
-          QEMU_VERSION="v4.0.0"
+          QEMU_VERSION="506179e42112be77bfd071f050b15762d3b2cd43"
           BUILDMAN="^evb-ast2500$"
     - name: "test/py vexpress_ca15_tc2"
       env:
Signature · 1 line
2.20.1
#13 lore raw

PATCH 1/1 gitlab-ci: Add evb-ast2500 test.py test

Bring us back into line with current Travis tests.

---
 .gitlab-ci.yml | 10 ++++++++++
 1 file changed, 10 insertions(+)
.gitlab-ci.yml +10 -0
index 3ddd5ad99a85..cb636b25a61e 100644
@@ -159,6 +159,16 @@ sandbox_spl test.py:
     TEST_PY_TEST_SPEC: "test_ofplatdata"
   <<: *buildman_and_testpy_dfn
 
+evb-ast2500 test.py:
+  tags: [ 'all' ]
+  variables:
+    TEST_PY_BD: "evb-ast2500"
+    TEST_PY_ID: "--id qemu"
+    QEMU_TARGET: "arm-softmmu"
+    QEMU_VERSION: "506179e42112be77bfd071f050b15762d3b2cd43"
+    BUILDMAN: "^evb-ast2500$"
+  <<: *buildman_and_testpy_dfn
+
 sandbox_flattree test.py:
   tags: [ 'all' ]
   variables:
Signature · 1 line
2.7.4
#14 lore raw

PATCH 5/5 travis: Build aspeed board with qemu HEAD

In reply to Joel Stanley
Quoted 7 lines · Joel Stanley

In order to boot u-boot in the aspeed machine we need to run at least qemu 3059c2f5a813 (v4.0.0-1592-g3059c2f5a813), which is not in a released tag.

This should be changed to v4.1.0 when it is released.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190718/6201054f/attachment.sig>
#15 lore raw

cover travis: Build and test ASPEED board

In reply to Joel Stanley

Hello,

Quoted 9 lines · Joel Stanley

Tom suggested I add support for booting the ASPEED EVB configuration in Qemu. This series fixes up a few things with the defconfig so buildman passes, and makes u-boot testable:

https://travis-ci.com/shenki/u-boot/builds/117772801

I've sent some patches to Stephen for uboot-test-scripts tools that need to be merged before this Travis configuration can go in.

Stephen has merged the uboot-test-scripts patches now. How do I go about getting this series merged?

Cheers,

Joel

Quoted 15 lines

Joel Stanley (5):
configs: aspeed: Unset CONFIG_MMC
configs: aspeed: Add HUSH and random ethernet addr
traivs: Build aspeed boards
travis: Add ASPEED ast2500 to qemu tests
travis: Build aspeed board with qemu HEAD

 .travis.yml                   | 10 ++++++++++
 configs/evb-ast2500_defconfig |  3 +++
 2 files changed, 13 insertions(+)

--
2.20.1

#16 lore raw

cover travis: Build and test ASPEED board

Quoted 8 lines · Joel Stanley

Hello,

Quoted 5 lines · Joel Stanley

Tom suggested I add support for booting the ASPEED EVB configuration in Qemu. This series fixes up a few things with the defconfig so buildman passes, and makes u-boot testable:

Quoted 7 lines
Quoted 4 lines

https://travis-ci.com/shenki/u-boot/builds/117772801

I've sent some patches to Stephen for uboot-test-scripts tools that need to be merged before this Travis configuration can go in.

Stephen has merged the uboot-test-scripts patches now. How do I go about getting this series merged?

I will apply it soon, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190717/dec53adb/attachment.sig>