AM33xx: Fix bad addressing in PLL dividers setting
Subsystems (3)
PATCH 1/1 AM33xx: Fix bad addressing in PLL dividers setting
Original code aborts always. The bug was unnoticed probably because 'if' condition was never met. when using xtal frequency 25MHz, it blows up.
Signed-off-by Martin Devera <[email protected]>
--- arch/arm/mach-omap2/am33xx/clock.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-omap2/am33xx/clock.c +5 -5
@@ -20,15 +20,15 @@ static void setup_post_dividers(const struct dpll_regs *dpll_regs, {/* Setup post-dividers */ if (params->m2 >=0 ) -writel (params->m2, dpll_regs->cm_div_m2_dpll); +writel (params->m2, &dpll_regs->cm_div_m2_dpll);if (params->m3 >=0 ) -writel (params->m3, dpll_regs->cm_div_m3_dpll); +writel (params->m3, &dpll_regs->cm_div_m3_dpll);if (params->m4 >=0 ) -writel (params->m4, dpll_regs->cm_div_m4_dpll); +writel (params->m4, &dpll_regs->cm_div_m4_dpll);if (params->m5 >=0 ) -writel (params->m5, dpll_regs->cm_div_m5_dpll); +writel (params->m5, &dpll_regs->cm_div_m5_dpll);if (params->m6 >=0 ) -writel (params->m6, dpll_regs->cm_div_m6_dpll); +writel (params->m6, &dpll_regs->cm_div_m6_dpll); }static inline void do_lock_dpll (const struct dpll_regs *dpll_regs)
Signature · 1 line
2.11.0
PATCH 1/1 AM33xx: Fix bad addressing in PLL dividers setting
Quoted 24 lines · Martin Devera
Original code aborts always. The bug was unnoticed probably because 'if' condition was never met. when using xtal frequency 25MHz, it blows up.
Signed-off-by Martin Devera <[email protected]>--- arch/arm/mach-omap2/am33xx/clock.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)arch/arm/mach-omap2/am33xx/clock.c +2
-3@@ -20,15 +20,15 @@ static void setup_post_dividers(const struct dpll_regs *dpll_regs, {/* Setup post-dividers */ if (params->m2 >=0 ) -writel (params->m2, dpll_regs->cm_div_m2_dpll); +writel (params->m2, &dpll_regs->cm_div_m2_dpll);if (params->m3 >=0 ) -writel (params->m3, dpll_regs->cm_div_m3_dpll); +writel (params->m3, &dpll_regs->cm_div_m3_dpll);if (params->m4 >=0 ) -writel (params->m4, dpll_regs->cm_div_m4_dpll);
arch/arm/mach-omap2/am33xx/clock.c static void setup_post_dividers(const struct dpll_regs *dpll_regs, · line 34
Quoted 10 lines
arch/arm/mach-omap2/am33xx/clock.c +3
-2+writel (params->m4, &dpll_regs->cm_div_m4_dpll);if (params->m5 >=0 ) -writel (params->m5, dpll_regs->cm_div_m5_dpll); +writel (params->m5, &dpll_regs->cm_div_m5_dpll);if (params->m6 >=0 ) -writel (params->m6, dpll_regs->cm_div_m6_dpll); +writel (params->m6, &dpll_regs->cm_div_m6_dpll); }static inline void do_lock_dpll (const struct dpll_regs *dpll_regs)
This causes my AM335x GP EVM to fail to boot (no output at all in SPL).
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190717/d6696720/attachment.sig>