drm/amdgpu/pm: remove check for pp funcs in freq sysfs handlers
Subsystems (2)
PATCH 1/1 drm/amdgpu/pm: remove check for pp funcs in freq sysfs handlers
The dpm sensor function already does this for us. This fixes the freq*_input files with the new SMU implementation.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 10 ---------- 1 file changed, 10 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +0 -10
@@ -2077,11 +2077,6 @@ static ssize_t amdgpu_hwmon_show_sclk(struct device *dev, (ddev->switch_power_state != DRM_SWITCH_POWER_ON))return -EINVAL ; -/* sanity check PP is enabled */ -if (!(adev->powerplay.pp_funcs && - adev->powerplay.pp_funcs->read_sensor)) -return -EINVAL ; -/* get the sclk */ r =amdgpu_dpm_read_sensor (adev,AMDGPU_PP_SENSOR_GFX_SCLK , (void *)&sclk, &size);
@@ -2112,11 +2107,6 @@ static ssize_t amdgpu_hwmon_show_mclk(struct device *dev, (ddev->switch_power_state != DRM_SWITCH_POWER_ON))return -EINVAL ; -/* sanity check PP is enabled */ -if (!(adev->powerplay.pp_funcs && - adev->powerplay.pp_funcs->read_sensor)) -return -EINVAL ; -/* get the sclk */ r =amdgpu_dpm_read_sensor (adev,AMDGPU_PP_SENSOR_GFX_MCLK , (void *)&mclk, &size);
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190717181527.6492-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Quan, Evan
Reviewed-by Evan QuanQuoted 53 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Thursday, July 18, 2019 2:15 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu/pm: remove check for pp funcs in freq sysfs handlersThe dpm sensor function already does this for us. This fixes the freq*_input files with the new SMU implementation.
Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +0
-5@@ -2077,11 +2077,6 @@ static ssize_t amdgpu_hwmon_show_sclk(struct device *dev, (ddev->switch_power_state != DRM_SWITCH_POWER_ON))return -EINVAL ; -/* sanity check PP is enabled */ -if (!(adev->powerplay.pp_funcs && - adev->powerplay.pp_funcs->read_sensor)) -return -EINVAL ; -/* get the sclk */ r = amdgpu_dpm_read_sensor(adev,
AMDGPU_PP_SENSOR_GFX_SCLK,drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +0
-5(void *)&sclk, &size);@@ -2112,11 +2107,6 @@ static ssize_t amdgpu_hwmon_show_mclk(struct device *dev, (ddev->switch_power_state != DRM_SWITCH_POWER_ON))return -EINVAL ; -/* sanity check PP is enabled */ -if (!(adev->powerplay.pp_funcs && - adev->powerplay.pp_funcs->read_sensor)) -return -EINVAL ; -/* get the sclk */ r = amdgpu_dpm_read_sensor(adev,
AMDGPU_PP_SENSOR_GFX_MCLK,
(void *)&mclk, &size);
--
2.20.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx