Skip to contentSkip to conversation

pwm: mxs: use devm_platform_ioremap_resource() to simplify code

PATCH In review [email protected] 3 participants 5 messages Jul 18, 2019 – Sep 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwm: mxs: use devm_platform_ioremap_resource() to simplify code

From: Anson Huang <[email protected]>

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

---
 drivers/pwm/pwm-mxs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-mxs.c +1 -3
index 04c0f6b..b14376b 100644
@@ -126,15 +126,13 @@ static int mxs_pwm_probe(struct platform_device *pdev)
 {
 	struct device_node *np = pdev->dev.of_node;
 	struct mxs_pwm_chip *mxs;
-	struct resource *res;
 	int ret;
 
 	mxs = devm_kzalloc(&pdev->dev, sizeof(*mxs), GFP_KERNEL);
 	if (!mxs)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mxs->base = devm_ioremap_resource(&pdev->dev, res);
+	mxs->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mxs->base))
 		return PTR_ERR(mxs->base);
 
Signature · 1 line
2.7.4
#3 lore raw

Hello,

Quoted 1 line · Anson Huang

Gentle ping...

My impression[1] is that Thierry collects patches in bulk once or twice per release cycle. The last two such bulks were between 5.2-rc6 and 5.2-rc7 and in the 5.2 merge window. So given we're at v5.3-rc5 now I expect some action soon :-)

Quoted 10 lines
Quoted 10 lines
Quoted 8 lines

From: [email protected] <[email protected]>
Sent: Thursday, July 18, 2019 9:32 AM

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

Best regards
Uwe

[1] from git log --committer=Thierry --format=%ci drivers/pwm | cut -d\ -f1 | uniq -c

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw

Ping..., 1 month passed, NOT sure what is the latest status.

Anson

Quoted 25 lines · Anson Huang
Quoted 1 line

Gentle ping...

My impression[1] is that Thierry collects patches in bulk once or twice per release cycle. The last two such bulks were between 5.2-rc6 and 5.2-rc7 and in the 5.2 merge window. So given we're at v5.3-rc5 now I expect some action soon :-)

Quoted 11 lines
Quoted 11 lines
Quoted 9 lines

From: [email protected] <[email protected]>
Sent: Thursday, July 18, 2019 9:32 AM

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

Best regards
Uwe

Quoted 10 lines

[1] from git log --committer=Thierry --format=%ci drivers/pwm | cut -d\ -f1 | uniq -c
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions |
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
engutronix.de%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7C34 ed78e5b90642e6173d08d72829bc65%7C686ea1d3bc2b4c6fa92cd99c5c30163 5%7C0%7C0%7C637022032026755310&amp;sdata=RM0DjN9B%2FomxSSlGp adxX50yYesNjOAFTXaghkxyOCQ%3D&amp;reserved=0 |

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel