Skip to contentSkip to conversation

content: explicitly document the VLAN filtering as best-effort

RFC In review Tiwei Bie 2 participants 2 messages Jul 18, 2019

lore
Share & tools
lore

Tiwei Bie

author
#0 lore raw

RFC 1/1 content: explicitly document the VLAN filtering as best-effort

Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave.

---
This is a RFC for now (Comments would be appreciated!). More details can be found here:
https://patchwork.ozlabs.org/patch/1113538/

 content.tex | 5 +++++
 1 file changed, 5 insertions(+)
content.tex +5 -0
index 8f0498e..783322b 100644
@@ -3530,6 +3530,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 If the driver negotiates the VIRTION_NET_F_CTRL_VLAN feature, it
 can control a VLAN filter table in the device.
 
+\begin{note}
+Similar to the MAC address based filtering, the VLAN filtering
+is also best-effort: unwanted packets could still arrive.
+\end{note}
+
 \begin{lstlisting}
 #define VIRTIO_NET_CTRL_VLAN       2
  #define VIRTIO_NET_CTRL_VLAN_ADD             0
Signature · 6 lines
2.17.1


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tiwei Bie

Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave.

fine by me.

Quoted 26 lines

---
This is a RFC for now (Comments would be appreciated!). More details can be found here:
https://patchwork.ozlabs.org/patch/1113538/

 content.tex | 5 +++++
 1 file changed, 5 insertions(+)
content.tex +5 -0
index 8f0498e..783322b 100644
@@ -3530,6 +3530,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 If the driver negotiates the VIRTION_NET_F_CTRL_VLAN feature, it
 can control a VLAN filter table in the device.
 
+\begin{note}
+Similar to the MAC address based filtering, the VLAN filtering
+is also best-effort: unwanted packets could still arrive.
+\end{note}
+
 \begin{lstlisting}
 #define VIRTIO_NET_CTRL_VLAN       2
  #define VIRTIO_NET_CTRL_VLAN_ADD             0
Signature · 1 line
2.17.1

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]