Skip to contentSkip to conversation

liquidio: Replace vmalloc + memset with vzalloc

PATCH Applied Chuhong Yuan 2 participants 2 messages Jul 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 liquidio: Replace vmalloc + memset with vzalloc

Use vzalloc and vzalloc_node instead of using vmalloc and vmalloc_node and then zeroing the allocated memory by memset 0.
This simplifies the code.

---
 drivers/net/ethernet/cavium/liquidio/request_manager.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/cavium/liquidio/request_manager.c +2 -4
index fcf20a8f92d9..032224178b64 100644
@@ -218,15 +218,13 @@ int octeon_setup_iq(struct octeon_device *oct,
 		return 0;
 	}
 	oct->instr_queue[iq_no] =
-	    vmalloc_node(sizeof(struct octeon_instr_queue), numa_node);
+	    vzalloc_node(sizeof(struct octeon_instr_queue), numa_node);
 	if (!oct->instr_queue[iq_no])
 		oct->instr_queue[iq_no] =
-		    vmalloc(sizeof(struct octeon_instr_queue));
+		    vzalloc(sizeof(struct octeon_instr_queue));
 	if (!oct->instr_queue[iq_no])
 		return 1;
 
-	memset(oct->instr_queue[iq_no], 0,
-	       sizeof(struct octeon_instr_queue));
 
 	oct->instr_queue[iq_no]->q_index = q_index;
 	oct->instr_queue[iq_no]->app_ctx = app_ctx;
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw

From: Chuhong Yuan <[email protected]>
Date: Thu, 18 Jul 2019 15:45:42 +0800

Quoted 6 lines

Use vzalloc and vzalloc_node instead of using vmalloc and vmalloc_node and then zeroing the allocated memory by memset 0.
This simplifies the code.

Applied.