Skip to contentSkip to conversation

drm/arm/mali-dp: Add display QoS interface configuration

PATCH Superseded Wen He 2 participants 5 messages Jul 17, 2019 – Jul 18, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Wen He

author
#0 lore raw

PATCH 1/1 drm/arm/mali-dp: Add display QoS interface configuration

Configure the display Quality of service (QoS) levels to high priority if the level is defined as high as in DTS. The ARQOS for DP500 is driven from the "RQOS" register, needed to program the RQOS register value < 7 for the 4k resolution flicker to disappear on the LS1028A platform.

---
change in v2:
- add new implementation for 4k flicker issue on the LS1028A

 drivers/gpu/drm/arm/malidp_drv.c  |  5 +++++
 drivers/gpu/drm/arm/malidp_hw.c   | 13 +++++++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 12 ++++++++++++
 4 files changed, 33 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +5 -0
index f25ec4382277..d2b2cf52ac87 100644
@@ -818,6 +818,11 @@ static int malidp_bind(struct device *dev)
 
 	malidp->core_id = version;
 
+	hwdev->arqos_high_level = false;
+
+	hwdev->arqos_high_level = of_property_read_bool(dev->of_node,
+					"arm,malidp-arqos-high-level");
+
 	/* set the number of lines used for output of RGB data */
 	ret = of_property_read_u8_array(dev->of_node,
 					"arm,malidp-output-port-lines",
drivers/gpu/drm/arm/malidp_hw.c +13 -0
index 50af399d7f6f..eaa1658cd86b 100644
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *
 		malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
 	else
 		malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
+
+	/*
+	 *  Program the RQoS register to increasing QoS levels for
+	 *  the 4k resolution flicker to disappear on the LS1028A.
+	 */
+	if (hwdev->arqos_high_level) {
+		val = RED_ARQOS_VALUE | GREEN_ARQOS_VALUE;
+
+		if (mode->pixelclock == 594000000)
+			malidp_hw_setbits(hwdev, val, MALIDP500_RQOS_QUALITY);
+		else
+			malidp_hw_clearbits(hwdev, val, MALIDP500_RQOS_QUALITY);
+	}
 }
 
 int malidp_format_get_bpp(u32 fmt)
drivers/gpu/drm/arm/malidp_hw.h +3 -0
index 968a65eed371..b8baba60508a 100644
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
 	/* size of memory used for rotating layers, up to two banks available */
 	u32 rotation_memory[2];
+
+	/* priority level of RQOS register used for driven the ARQOS signal */
+	bool arqos_high_level;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32 reg)
drivers/gpu/drm/arm/malidp_regs.h +12 -0
index 993031542fa1..08842142b3b2 100644
@@ -210,6 +210,18 @@
 #define MALIDP500_CONFIG_VALID		0x00f00
 #define MALIDP500_CONFIG_ID		0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register values
+ * are driven by the ARQOS signal, using AXI transacations, dependent on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow conditions
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+#define RED_ARQOS_VALUE                 (0xd << 12)
+#define GREEN_ARQOS_VALUE               (0xd << 28)
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE	0x10000
 #define MALIDP550_DE_CONTROL		0x00010
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Hi Wen,

Quoted 4 lines · Wen He

Configure the display Quality of service (QoS) levels to high priority if the level is defined as high as in DTS. The ARQOS for DP500 is driven from the "RQOS" register, needed to program the RQOS register value < 7 for the 4k resolution flicker to disappear on the LS1028A platform.

Thanks for taking time to come up with a more generic patch for your issue!

I have a question: what happens if you program the MALIDP500_RQOS_QUALITY register to 0xd000d000 for all pixelclocks?

Also, some suggestions further down:

Quoted 17 lines

---
change in v2:
- add new implementation for 4k flicker issue on the LS1028A

 drivers/gpu/drm/arm/malidp_drv.c  |  5 +++++
 drivers/gpu/drm/arm/malidp_hw.c   | 13 +++++++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 12 ++++++++++++
 4 files changed, 33 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +0 -0
index f25ec4382277..d2b2cf52ac87 100644

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 821

Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
@@ -818,6 +818,11 @@ static int malidp_bind(struct device *dev)
 
 	malidp->core_id = version;
 
+	hwdev->arqos_high_level = false;

This is not needed.

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 824

Quoted 3 lines
drivers/gpu/drm/arm/malidp_drv.c +3 -0
+
+	hwdev->arqos_high_level = of_property_read_bool(dev->of_node,
+					"arm,malidp-arqos-high-level");

I think it would be better to have this property as a u32 value, rather than a boolean, and put the value that we want to program MALIDP_RQOS_QUALITY with in there.

Also, you need to add the documentation for this optional property in Documentation/devicetree/bindings/display/arm,malidp.txt.

Quoted 9 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
+
 	/* set the number of lines used for output of RGB data */
 	ret = of_property_read_u8_array(dev->of_node,
 					"arm,malidp-output-port-lines",
drivers/gpu/drm/arm/malidp_hw.c +0 -0
index 50af399d7f6f..eaa1658cd86b 100644

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 380

Quoted 7 lines
drivers/gpu/drm/arm/malidp_hw.c +4 -0
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *
 		malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
 	else
 		malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
+
+	/*
+	 *  Program the RQoS register to increasing QoS levels for
+	 *  the 4k resolution flicker to disappear on the LS1028A.

Looks like two sentences got smashed into one, the result is a bit hard to read.

Best regards,
Liviu

Quoted 52 lines
drivers/gpu/drm/arm/malidp_hw.c +9 -0
+	 */
+	if (hwdev->arqos_high_level) {
+		val = RED_ARQOS_VALUE | GREEN_ARQOS_VALUE;
+
+		if (mode->pixelclock == 594000000)
+			malidp_hw_setbits(hwdev, val, MALIDP500_RQOS_QUALITY);
+		else
+			malidp_hw_clearbits(hwdev, val, MALIDP500_RQOS_QUALITY);
+	}
 }
 
 int malidp_format_get_bpp(u32 fmt)
drivers/gpu/drm/arm/malidp_hw.h +3 -0
index 968a65eed371..b8baba60508a 100644
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
 	/* size of memory used for rotating layers, up to two banks available */
 	u32 rotation_memory[2];
+
+	/* priority level of RQOS register used for driven the ARQOS signal */
+	bool arqos_high_level;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32 reg)
drivers/gpu/drm/arm/malidp_regs.h +12 -0
index 993031542fa1..08842142b3b2 100644
@@ -210,6 +210,18 @@
 #define MALIDP500_CONFIG_VALID		0x00f00
 #define MALIDP500_CONFIG_ID		0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register values
+ * are driven by the ARQOS signal, using AXI transacations, dependent on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow conditions
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+#define RED_ARQOS_VALUE                 (0xd << 12)
+#define GREEN_ARQOS_VALUE               (0xd << 28)
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE	0x10000
 #define MALIDP550_DE_CONTROL		0x00010
Signature · 1 line
2.17.1
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
author
#2 lore raw
Quoted 13 lines

-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月17日 19:22
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [PATCH] drm/arm/mali-dp: Add display QoS interface configuration

Quoted 2 lines

Hi Wen,

Hi Liviu,

Quoted 8 lines · Wen He
Quoted 4 lines

Configure the display Quality of service (QoS) levels to high priority if the level is defined as high as in DTS. The ARQOS for DP500 is driven from the "RQOS" register, needed to program the RQOS register value < 7 for the 4k resolution flicker to disappear on the LS1028A platform.

Thanks for taking time to come up with a more generic patch for your issue!

Thanks for the review and comments,

Quoted 3 lines

I have a question: what happens if you program the MALIDP500_RQOS_QUALITY register to 0xd000d000 for all pixelclocks?

We can't do that, because:
1. The flicker issue only reproduced in 4k@60.
2. This configuration will be reduced DDR benchmark performance data, because the LCDC and DDR are both to connect CCI-400. we have to make sure that DDR performance at first when work together with other resolutions.

Quoted 27 lines

Also, some suggestions further down:

Quoted 18 lines

---
change in v2:
- add new implementation for 4k flicker issue on the LS1028A

 drivers/gpu/drm/arm/malidp_drv.c  |  5 +++++
 drivers/gpu/drm/arm/malidp_hw.c   | 13 +++++++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 12 ++++++++++++
 4 files changed, 33 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +0 -0
index f25ec4382277..d2b2cf52ac87 100644

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 821

Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
@@ -818,6 +818,11 @@ static int malidp_bind(struct device *dev)
 
      malidp->core_id = version;
 
+     hwdev->arqos_high_level = false;

This is not needed.

Quoted 7 lines

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 824

Quoted 3 lines
drivers/gpu/drm/arm/malidp_drv.c +3 -0
+
+     hwdev->arqos_high_level = of_property_read_bool(dev->of_node,
+                                     "arm,malidp-arqos-high-level");

I think it would be better to have this property as a u32 value, rather than a boolean, and put the value that we want to program MALIDP_RQOS_QUALITY with in there.

I really thought that, but I've tested DDR performance for 4k resolution with different RQOS setting, the best test performance data is when set the RQOS register value's 0xd000d000. So the value is fixed, I think the Boolean type is better used here, that's why I did it.

Quoted 3 lines

Also, you need to add the documentation for this optional property in Documentation/devicetree/bindings/display/arm,malidp.txt.

Understand, I will generate another patch to add this change for the DT bindings.

Quoted 23 lines

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct

Quoted 12 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
+
      /* set the number of lines used for output of RGB data */
      ret = of_property_read_u8_array(dev->of_node,
                                      "arm,malidp-output-port-lines",
(quoted diff) +0 -0

b/drivers/gpu/drm/arm/malidp_hw.c index 50af399d7f6f..eaa1658cd86b 100644

drivers/gpu/drm/arm/malidp_hw.c +0 -0
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct

malidp_hw_device *hwdev, struct videomode *

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374

Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0 -0
              malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,

MALIDP_DE_DISPLAY_FUNC);

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 380

Quoted 7 lines
drivers/gpu/drm/arm/malidp_hw.c +4 -0
      else
              malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED,
 MALIDP_DE_DISPLAY_FUNC);
+
+     /*
+      *  Program the RQoS register to increasing QoS levels for
+      *  the 4k resolution flicker to disappear on the LS1028A.
Quoted 2 lines

Looks like two sentences got smashed into one, the result is a bit hard to read.

Ha, maybe should be described like this:
"Program the RQoS register to avoid 4k resolution flicker on the LS1028A."

Best Regards,
Wen

Quoted 73 lines

Best regards,
Liviu

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *

Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +6 -0
+      */
+     if (hwdev->arqos_high_level) {
+             val = RED_ARQOS_VALUE | GREEN_ARQOS_VALUE;
+
+             if (mode->pixelclock == 594000000)
+                     malidp_hw_setbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389

Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2 -0
+             else
+                     malidp_hw_clearbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

drivers/gpu/drm/arm/malidp_hw.h struct malidp_hw_device { · line 252

Quoted 12 lines
drivers/gpu/drm/arm/malidp_hw.c +1 -0
+     }
 }
 

int malidp_format_get_bpp(u32 fmt)

(quoted diff) +0 -0

b/drivers/gpu/drm/arm/malidp_hw.h index 968a65eed371..b8baba60508a 100644

drivers/gpu/drm/arm/malidp_hw.h +0 -0
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
      /* size of memory used for rotating layers, up to two banks available

*/

Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.h +3 -0
      u32 rotation_memory[2];
+
+     /* priority level of RQOS register used for driven the ARQOS signal */
+     bool arqos_high_level;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32

reg) diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h
index 993031542fa1..08842142b3b2 100644

drivers/gpu/drm/arm/malidp_regs.h +0 -0
@@ -210,6 +210,18 @@
 #define MALIDP500_CONFIG_VALID               0x00f00

drivers/gpu/drm/arm/malidp_regs.h line 220

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8 -0
 #define MALIDP500_CONFIG_ID          0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register
+values
+ * are driven by the ARQOS signal, using AXI transacations, dependent
+on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow

conditions

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +6 -1
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+#define RED_ARQOS_VALUE                 (0xd << 12)
+#define GREEN_ARQOS_VALUE               (0xd << 28)
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE    0x10000
 #define MALIDP550_DE_CONTROL         0x00010
--
Quoted 2 lines

2.17.1

--
====================

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
maintainer
#3 lore raw
Quoted 13 lines · Wen He
Quoted 13 lines

-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月17日 19:22
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [PATCH] drm/arm/mali-dp: Add display QoS interface configuration

Quoted 4 lines
Quoted 2 lines

Hi Wen,

Hi Liviu,

Hi Wen,

Quoted 10 lines
Quoted 9 lines · Wen He
Quoted 4 lines

Configure the display Quality of service (QoS) levels to high priority if the level is defined as high as in DTS. The ARQOS for DP500 is driven from the "RQOS" register, needed to program the RQOS register value < 7 for the 4k resolution flicker to disappear on the LS1028A platform.

Thanks for taking time to come up with a more generic patch for your issue!

Quoted 8 lines

Thanks for the review and comments,

Quoted 3 lines

I have a question: what happens if you program the MALIDP500_RQOS_QUALITY register to 0xd000d000 for all pixelclocks?

We can't do that, because:
1. The flicker issue only reproduced in 4k@60.

Can you clarify? Does this mean that with the RQOS setting of 0xd000d000 you don't see flicker at lower resolutions, or that you haven't tested at other resolution than 4k@60?

Quoted 3 lines

2. This configuration will be reduced DDR benchmark performance data, because the LCDC and DDR are both to connect CCI-400. we have to make sure that DDR performance at first when work together with other resolutions.

Hmm, I'm not sure I'm sharing the same view of the problem. You are writing into DP500's QoS registers, which don't control how CCI-400 or DDR are going to behave. Now I agree that a more aggressive QoS from DP500 is going to lead to more contention to the DDR, but maybe you can look into CCI-400's QoS settings and tweak the bandwidth allocation there as well.

Quoted 32 lines
Quoted 32 lines

Also, some suggestions further down:

Quoted 18 lines

---
change in v2:
- add new implementation for 4k flicker issue on the LS1028A

 drivers/gpu/drm/arm/malidp_drv.c  |  5 +++++
 drivers/gpu/drm/arm/malidp_hw.c   | 13 +++++++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 12 ++++++++++++
 4 files changed, 33 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +0 -0
index f25ec4382277..d2b2cf52ac87 100644

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 821

Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
@@ -818,6 +818,11 @@ static int malidp_bind(struct device *dev)
 
      malidp->core_id = version;
 
+     hwdev->arqos_high_level = false;

This is not needed.

Quoted 3 lines
drivers/gpu/drm/arm/malidp_drv.c +3 -0
+
+     hwdev->arqos_high_level = of_property_read_bool(dev->of_node,
+                                     "arm,malidp-arqos-high-level");
Quoted 8 lines
Quoted 3 lines

I think it would be better to have this property as a u32 value, rather than a boolean, and put the value that we want to program MALIDP_RQOS_QUALITY with in there.

I really thought that, but I've tested DDR performance for 4k resolution with different RQOS setting, the best test performance data is when set the RQOS register value's 0xd000d000. So the value is fixed, I think the Boolean type is better used here, that's why I did it.

Yes, it is fixed for your platform, but not fixed for other ODMs that might decide to use the LS1028A chip to create a board. They might use different DDRs, or their PCB traces might have different lengths. I think it is still valuable to put the 0xd000d000 value into the device tree and read it from there. For LS1028A NXP boards it will do then the right thing.

Quoted 30 lines
Quoted 4 lines

Also, you need to add the documentation for this optional property in Documentation/devicetree/bindings/display/arm,malidp.txt.

Understand, I will generate another patch to add this change for the DT bindings.

Quoted 23 lines

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct

Quoted 12 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
+
      /* set the number of lines used for output of RGB data */
      ret = of_property_read_u8_array(dev->of_node,
                                      "arm,malidp-output-port-lines",
(quoted diff) +0 -0

b/drivers/gpu/drm/arm/malidp_hw.c index 50af399d7f6f..eaa1658cd86b 100644

drivers/gpu/drm/arm/malidp_hw.c +0 -0
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct

malidp_hw_device *hwdev, struct videomode *

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374

Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0 -0
              malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,

MALIDP_DE_DISPLAY_FUNC);

Quoted 7 lines
drivers/gpu/drm/arm/malidp_hw.c +4 -0
      else
              malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED,
 MALIDP_DE_DISPLAY_FUNC);
+
+     /*
+      *  Program the RQoS register to increasing QoS levels for
+      *  the 4k resolution flicker to disappear on the LS1028A.
Quoted 5 lines
Quoted 2 lines

Looks like two sentences got smashed into one, the result is a bit hard to read.

Ha, maybe should be described like this:
"Program the RQoS register to avoid 4k resolution flicker on the LS1028A."

Yes, that is much easier to understand.

Thank you,
Liviu

Quoted 77 lines

Best Regards,
Wen

Quoted 73 lines

Best regards,
Liviu

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *

Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +6 -0
+      */
+     if (hwdev->arqos_high_level) {
+             val = RED_ARQOS_VALUE | GREEN_ARQOS_VALUE;
+
+             if (mode->pixelclock == 594000000)
+                     malidp_hw_setbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389

Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2 -0
+             else
+                     malidp_hw_clearbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

drivers/gpu/drm/arm/malidp_hw.h struct malidp_hw_device { · line 252

Quoted 12 lines
drivers/gpu/drm/arm/malidp_hw.c +1 -0
+     }
 }
 

int malidp_format_get_bpp(u32 fmt)

(quoted diff) +0 -0

b/drivers/gpu/drm/arm/malidp_hw.h index 968a65eed371..b8baba60508a 100644

drivers/gpu/drm/arm/malidp_hw.h +0 -0
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
      /* size of memory used for rotating layers, up to two banks available

*/

Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.h +3 -0
      u32 rotation_memory[2];
+
+     /* priority level of RQOS register used for driven the ARQOS signal */
+     bool arqos_high_level;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32

reg) diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h
index 993031542fa1..08842142b3b2 100644

drivers/gpu/drm/arm/malidp_regs.h +0 -0
@@ -210,6 +210,18 @@
 #define MALIDP500_CONFIG_VALID               0x00f00

drivers/gpu/drm/arm/malidp_regs.h line 220

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8 -0
 #define MALIDP500_CONFIG_ID          0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register
+values
+ * are driven by the ARQOS signal, using AXI transacations, dependent
+on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow

conditions

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +6 -1
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+#define RED_ARQOS_VALUE                 (0xd << 12)
+#define GREEN_ARQOS_VALUE               (0xd << 28)
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE    0x10000
 #define MALIDP550_DE_CONTROL         0x00010
--
Quoted 2 lines

2.17.1

--
====================

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
author
#4 lore raw
Quoted 53 lines

-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月18日 17:37
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: Re: [EXT] Re: [PATCH] drm/arm/mali-dp: Add display QoS interface configuration

Caution: EXT Email

Quoted 13 lines · Wen He
Quoted 13 lines

-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月17日 19:22
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [PATCH] drm/arm/mali-dp: Add display QoS interface configuration

Quoted 4 lines
Quoted 2 lines

Hi Wen,

Hi Liviu,

Hi Wen,

Quoted 6 lines
Quoted 6 lines · Wen He
Quoted 4 lines

Configure the display Quality of service (QoS) levels to high priority if the level is defined as high as in DTS. The ARQOS for DP500 is driven from the "RQOS" register, needed to program the RQOS register value < 7 for the 4k resolution flicker to disappear on the

LS1028A platform.

Quoted 2 lines
Quoted 2 lines

Thanks for taking time to come up with a more generic patch for your

issue!

Quoted 8 lines
Quoted 1 line

Thanks for the review and comments,

Quoted 3 lines

I have a question: what happens if you program the MALIDP500_RQOS_QUALITY register to 0xd000d000 for all pixelclocks?

Quoted 6 lines
Quoted 2 lines

We can't do that, because:
1. The flicker issue only reproduced in 4k@60.

Can you clarify? Does this mean that with the RQOS setting of 0xd000d000 you don't see flicker at lower resolutions, or that you haven't tested at other resolution than 4k@60?

I mean that I didn't see flicker issue at lower resolutions without the RQOS setting of 0xd000d000.

The ROQS register default value's 0x00010001, in this case, only found the flicker issue can be reproduced in 4k@60, other lower resolutions not found this issue. So If setting the RQOS register value's to 0xd001d001, 4k flicker issue will be resolve.

Quoted 11 lines
Quoted 4 lines

2. This configuration will be reduced DDR benchmark performance data, because the LCDC and DDR are both to connect CCI-400. we have to make sure that DDR performance at first when work together with other

resolutions.

Hmm, I'm not sure I'm sharing the same view of the problem. You are writing into DP500's QoS registers, which don't control how CCI-400 or DDR are going to behave. Now I agree that a more aggressive QoS from DP500 is going to lead to more contention to the DDR, but maybe you can look into CCI-400's QoS settings and tweak the bandwidth allocation there as well.

Yes, I agree with you, but after discussed with our design team, I chose them advice that only change the DP500's QoS.
Here're comments from our design team:
-------------------
There are multiple registers that impact QOS values in the system, particularly as it relates to transactions from the LCD Controller.
"The “best” approach (which in theory should result in the LCD Controller having the bandwidth it needs to avoid buffer underrun, while also having the minimal impact on the system) is to use the dynamic QoS information (ARQOS) coming from the LCD Controller. To do this, you need to program the LCD Controller’s “RQOS” register. See the attached DP-500 TRM, Section 2.4.6, “Display Quality of Service Interface” and Section 4.2.9, “Display engine quality of service registers”.
-------------------

Quoted 44 lines
Quoted 39 lines
Quoted 30 lines

Also, some suggestions further down:

Quoted 19 lines

---
change in v2:
- add new implementation for 4k flicker issue on the
LS1028A

 drivers/gpu/drm/arm/malidp_drv.c  |  5 +++++
 drivers/gpu/drm/arm/malidp_hw.c   | 13 +++++++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 12 ++++++++++++
 4 files changed, 33 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +0 -0
index f25ec4382277..d2b2cf52ac87 100644

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 821

Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
@@ -818,6 +818,11 @@ static int malidp_bind(struct device *dev)
 
      malidp->core_id = version;
 
+     hwdev->arqos_high_level = false;

This is not needed.

Quoted 8 lines

drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev)

Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c +4 -0
+
+     hwdev->arqos_high_level = of_property_read_bool(dev->of_node,
+
+ "arm,malidp-arqos-high-level");

I think it would be better to have this property as a u32 value, rather than a boolean, and put the value that we want to program MALIDP_RQOS_QUALITY with in there.

Quoted 4 lines

I really thought that, but I've tested DDR performance for 4k resolution with different RQOS setting, the best test performance data is when set the RQOS register value's 0xd000d000. So the value is fixed, I think the Boolean type is better used here, that's why I did it.

Quoted 6 lines

Yes, it is fixed for your platform, but not fixed for other ODMs that might decide to use the LS1028A chip to create a board. They might use different DDRs, or their PCB traces might have different lengths. I think it is still valuable to put the 0xd000d000 value into the device tree and read it from there. For LS1028A NXP boards it will do then the right thing.

Hmm, I think you are right, should be use value to instead of the Boolean.

Quoted 33 lines
Quoted 6 lines
Quoted 4 lines

Also, you need to add the documentation for this optional property in Documentation/devicetree/bindings/display/arm,malidp.txt.

Understand, I will generate another patch to add this change for the DT

bindings.

Quoted 15 lines
Quoted 15 lines

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct

Quoted 14 lines
drivers/gpu/drm/arm/malidp_drv.c +1 -0
+
      /* set the number of lines used for output of RGB data */
      ret = of_property_read_u8_array(dev->of_node,

"arm,malidp-output-port-lines", diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 50af399d7f6f..eaa1658cd86b 100644

drivers/gpu/drm/arm/malidp_hw.c +0 -0
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct

malidp_hw_device *hwdev, struct videomode *

Quoted 4 lines
Quoted 4 lines

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374

Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0 -0
              malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,

MALIDP_DE_DISPLAY_FUNC);

Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +0 -0
      else
              malidp_hw_clearbits(hwdev,

MALIDP_DISP_FUNC_ILACED,

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
drivers/gpu/drm/arm/malidp_hw.c +4 -0
 MALIDP_DE_DISPLAY_FUNC);
+
+     /*
+      *  Program the RQoS register to increasing QoS levels for
+      *  the 4k resolution flicker to disappear on the LS1028A.
Quoted 9 lines
Quoted 1 line
Quoted 1 line

Looks like two sentences got smashed into one, the result is a bit hard to

read.

Quoted 4 lines
Quoted 1 line

Ha, maybe should be described like this:
"Program the RQoS register to avoid 4k resolution flicker on the LS1028A."

Yes, that is much easier to understand.

Thank you for the detailed review.

Best Regards,
Wen

Quoted 95 lines

Thank you,
Liviu

Quoted 23 lines

Best Regards,
Wen

Quoted 19 lines

Best regards,
Liviu

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *

Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +6 -0
+      */
+     if (hwdev->arqos_high_level) {
+             val = RED_ARQOS_VALUE | GREEN_ARQOS_VALUE;
+
+             if (mode->pixelclock == 594000000)
+                     malidp_hw_setbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389

Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2 -0
+             else
+                     malidp_hw_clearbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +1 -0
+     }
 }
 

int malidp_format_get_bpp(u32 fmt) diff --git
a/drivers/gpu/drm/arm/malidp_hw.h
b/drivers/gpu/drm/arm/malidp_hw.h index

968a65eed371..b8baba60508a

Quoted 11 lines
Quoted 11 lines
Quoted 7 lines

100644

drivers/gpu/drm/arm/malidp_hw.h +0 -0
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
      /* size of memory used for rotating layers, up to two banks

available

*/

Quoted 3 lines
      u32 rotation_memory[2];
drivers/gpu/drm/arm/malidp_hw.h +2 -0
+
+     /* priority level of RQOS register used for driven the ARQOS signal

*/

Quoted 37 lines
Quoted 37 lines
Quoted 12 lines

+ bool arqos_high_level;
};

static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev,
u32
reg) diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h
index 993031542fa1..08842142b3b2 100644

drivers/gpu/drm/arm/malidp_regs.h +0 -0
@@ -210,6 +210,18 @@
 #define MALIDP500_CONFIG_VALID               0x00f00

drivers/gpu/drm/arm/malidp_regs.h line 220

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8 -0
 #define MALIDP500_CONFIG_ID          0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS
+register values
+ * are driven by the ARQOS signal, using AXI transacations,
+dependent on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow

conditions

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +6 -1
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+#define RED_ARQOS_VALUE                 (0xd << 12)
+#define GREEN_ARQOS_VALUE               (0xd << 28)
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE    0x10000
 #define MALIDP550_DE_CONTROL         0x00010
--
Quoted 2 lines

2.17.1

--

Quoted 8 lines
Quoted 8 lines

====================

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

--
====================

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯